From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE58C79C0 for ; Wed, 30 Nov 2022 18:42:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4249EC433B5; Wed, 30 Nov 2022 18:42:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1669833753; bh=i0WQ1jGcAeTSonPJc2p1YEck6/7gCIgRErSmbZKXpnE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wLHTl7QpTGAqfmF+giaO35+9PXdmWQDbl7qot7aF0Wi7psGEywdVWzL/FgtGJMwCR 3GAmV1a+oK9uNm7HuUDXojBaudyrRqrw/C1qqmtovMAAuYZJG83qZZYHy0Ue9JgxEr 3FBjPQxamdSqcred+nAz5TYxvHeQIsR06JPqxmrI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Johannes Thumshirn , Qu Wenruo , Christoph Hellwig , David Sterba Subject: [PATCH 5.15 199/206] btrfs: zoned: fix missing endianness conversion in sb_write_pointer Date: Wed, 30 Nov 2022 19:24:11 +0100 Message-Id: <20221130180538.081205662@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221130180532.974348590@linuxfoundation.org> References: <20221130180532.974348590@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Christoph Hellwig commit c51f0e6a1254b3ac2d308e1c6fd8fb936992b455 upstream. generation is an on-disk __le64 value, so use btrfs_super_generation to convert it to host endian before comparing it. Fixes: 12659251ca5d ("btrfs: implement log-structured superblock for ZONED mode") CC: stable@vger.kernel.org # 5.15+ Reviewed-by: Johannes Thumshirn Reviewed-by: Qu Wenruo Signed-off-by: Christoph Hellwig Reviewed-by: David Sterba Signed-off-by: David Sterba Signed-off-by: Greg Kroah-Hartman --- fs/btrfs/zoned.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/fs/btrfs/zoned.c +++ b/fs/btrfs/zoned.c @@ -114,7 +114,8 @@ static int sb_write_pointer(struct block super[i] = page_address(page[i]); } - if (super[0]->generation > super[1]->generation) + if (btrfs_super_generation(super[0]) > + btrfs_super_generation(super[1])) sector = zones[1].start; else sector = zones[0].start;