From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 435C315C83 for ; Mon, 5 Dec 2022 19:24:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BCEC5C433C1; Mon, 5 Dec 2022 19:24:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1670268276; bh=IptsQPsjwnuQGBlRZzG3uTTy+8or39/mkD5ZRVBWo9s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RTt6l9uo/kiMkmogLcnUaGbe8BLTyg/kddlSbexqTX/VPIQvO0mmkV/jqnlxuzD4b G5AIJ7Bx2jD7Vn8WsyGm9Yj6pqaKCqB6QpROrwDAChgwbT93PR4egVjCRuiE6tElQq n14rHOBwMEa48lLpPAKllFRbGGGqt0wm95kc9Ogk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jiasheng Jiang , Marc Kleine-Budde , Sasha Levin Subject: [PATCH 6.0 043/124] can: m_can: Add check for devm_clk_get Date: Mon, 5 Dec 2022 20:09:09 +0100 Message-Id: <20221205190809.665662358@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221205190808.422385173@linuxfoundation.org> References: <20221205190808.422385173@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Jiasheng Jiang [ Upstream commit 68b4f9e0bdd0f920d7303d07bfe226cd0976961d ] Since the devm_clk_get may return error, it should be better to add check for the cdev->hclk, as same as cdev->cclk. Fixes: f524f829b75a ("can: m_can: Create a m_can platform framework") Signed-off-by: Jiasheng Jiang Link: https://lore.kernel.org/all/20221123063651.26199-1-jiasheng@iscas.ac.cn Signed-off-by: Marc Kleine-Budde Signed-off-by: Sasha Levin --- drivers/net/can/m_can/m_can.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index 4dc67fdfcdb9..153d8fd08bd8 100644 --- a/drivers/net/can/m_can/m_can.c +++ b/drivers/net/can/m_can/m_can.c @@ -1910,7 +1910,7 @@ int m_can_class_get_clocks(struct m_can_classdev *cdev) cdev->hclk = devm_clk_get(cdev->dev, "hclk"); cdev->cclk = devm_clk_get(cdev->dev, "cclk"); - if (IS_ERR(cdev->cclk)) { + if (IS_ERR(cdev->hclk) || IS_ERR(cdev->cclk)) { dev_err(cdev->dev, "no clock found\n"); ret = -ENODEV; } -- 2.35.1