From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9ED936FB4 for ; Mon, 19 Dec 2022 19:28:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F01A1C433EF; Mon, 19 Dec 2022 19:28:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1671478102; bh=BIJzCa1jozMtKFRXfyQ+lAV7aDa4aAWMPqucrOJnXK8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pZ4crhZMDw9jBZjf2muroEWmMugWWLQmj1jJOGc1aICiazueqqNlDfo+NIHw3MYof h6CPaq3Aht3bucSp32tJ0epWGfhEEEief1zo0CPGbwmu9QzXVMinrkELqseZpILmiK OjRRA1sbrJ9KV3ifJt77myTsa6A/Vy4PGrWrQte8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Heikki Krogerus , Ferry Toth Subject: [PATCH 5.10 12/18] usb: ulpi: defer ulpi_register on ulpi_read_id timeout Date: Mon, 19 Dec 2022 20:25:05 +0100 Message-Id: <20221219182941.070840527@linuxfoundation.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20221219182940.701087296@linuxfoundation.org> References: <20221219182940.701087296@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Ferry Toth commit 8a7b31d545d3a15f0e6f5984ae16f0ca4fd76aac upstream. Since commit 0f0101719138 ("usb: dwc3: Don't switch OTG -> peripheral if extcon is present") Dual Role support on Intel Merrifield platform broke due to rearranging the call to dwc3_get_extcon(). It appears to be caused by ulpi_read_id() on the first test write failing with -ETIMEDOUT. Currently ulpi_read_id() expects to discover the phy via DT when the test write fails and returns 0 in that case, even if DT does not provide the phy. As a result usb probe completes without phy. Make ulpi_read_id() return -ETIMEDOUT to its user if the first test write fails. The user should then handle it appropriately. A follow up patch will make dwc3_core_init() set -EPROBE_DEFER in this case and bail out. Fixes: ef6a7bcfb01c ("usb: ulpi: Support device discovery via DT") Cc: stable@vger.kernel.org Acked-by: Heikki Krogerus Signed-off-by: Ferry Toth Link: https://lore.kernel.org/r/20221205201527.13525-2-ftoth@exalondelft.nl Signed-off-by: Greg Kroah-Hartman --- drivers/usb/common/ulpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/usb/common/ulpi.c +++ b/drivers/usb/common/ulpi.c @@ -208,7 +208,7 @@ static int ulpi_read_id(struct ulpi *ulp /* Test the interface */ ret = ulpi_write(ulpi, ULPI_SCRATCH, 0xaa); if (ret < 0) - goto err; + return ret; ret = ulpi_read(ulpi, ULPI_SCRATCH); if (ret < 0)