From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D72D5187A for ; Wed, 28 Dec 2022 16:06:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 505B6C433D2; Wed, 28 Dec 2022 16:06:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1672243605; bh=7TqnwCsT1oUHJkOJRgf2HlNmIL3Ngnf8RQmgOAXpsCY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lxhFen6uiAtG5JIwwHj69h6amiezy3ue+TNNxoZinqwpYQwKl7pNl0FNmBi2V+Y/r aTxh7OTBX59UOgKta4B7jdmZ7XmqI+LT2NBb8TA9oPspNJsxYHwaevbM8CJusgjt6n ymvHNNCErUHpoxW0cq5fmmJclJiOLKar6JGlXwzY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Xiu Jianfeng , Alim Akhtar , Stephen Boyd , Sasha Levin Subject: [PATCH 6.1 0520/1146] clk: samsung: Fix memory leak in _samsung_clk_register_pll() Date: Wed, 28 Dec 2022 15:34:19 +0100 Message-Id: <20221228144344.299569305@linuxfoundation.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20221228144330.180012208@linuxfoundation.org> References: <20221228144330.180012208@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Xiu Jianfeng [ Upstream commit 5174e5b0d1b669a489524192b6adcbb3c54ebc72 ] If clk_register() fails, @pll->rate_table may have allocated memory by kmemdup(), so it needs to be freed, otherwise will cause memory leak issue, this patch fixes it. Fixes: 3ff6e0d8d64d ("clk: samsung: Add support to register rate_table for samsung plls") Signed-off-by: Xiu Jianfeng Link: https://lore.kernel.org/r/20221123032015.63980-1-xiujianfeng@huawei.com Reviewed-by: Alim Akhtar Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/samsung/clk-pll.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/samsung/clk-pll.c b/drivers/clk/samsung/clk-pll.c index fe383471c5f0..0ff28938943f 100644 --- a/drivers/clk/samsung/clk-pll.c +++ b/drivers/clk/samsung/clk-pll.c @@ -1583,6 +1583,7 @@ static void __init _samsung_clk_register_pll(struct samsung_clk_provider *ctx, if (ret) { pr_err("%s: failed to register pll clock %s : %d\n", __func__, pll_clk->name, ret); + kfree(pll->rate_table); kfree(pll); return; } -- 2.35.1