From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D315B1C08 for ; Wed, 28 Dec 2022 16:45:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59489C433D2; Wed, 28 Dec 2022 16:45:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1672245934; bh=RGJDOU0CQ402OaMUXRraXDNKYQZybk4l++nVvWs5NCY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IF2J9qpsLjL37T/eNZjMZHgpUVVr3x6Xqbh+OTbSurcfqwQGMBTtEfkcsALQAgq+a a9OBmFEa6aJqXoxrO8xe0yBL20+mFJ0IUCIr9gDjcnzcaGGaNfKIayQK+tokrnS9Hc fY+MQYoTt+gvzkRLpiSE1UgVAcJFtCYMwrfk4YEI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Bjorn Helgaas , Sasha Levin Subject: [PATCH 6.0 0983/1073] Revert "PCI: Clear PCI_STATUS when setting up device" Date: Wed, 28 Dec 2022 15:42:51 +0100 Message-Id: <20221228144354.786494603@linuxfoundation.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20221228144328.162723588@linuxfoundation.org> References: <20221228144328.162723588@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Bjorn Helgaas [ Upstream commit 44e985938e85503d0a69ec538e15fd33c1a4df05 ] This reverts commit 6cd514e58f12b211d638dbf6f791fa18d854f09c. Christophe Fergeau reported that 6cd514e58f12 ("PCI: Clear PCI_STATUS when setting up device") causes boot failures when trying to start linux guests with Apple's virtualization framework (for example using https://developer.apple.com/documentation/virtualization/running_linux_in_a_virtual_machine?language=objc) 6cd514e58f12 only solved a cosmetic problem, so revert it to fix the boot failures. Link: https://bugzilla.redhat.com/show_bug.cgi?id=2137803 Signed-off-by: Bjorn Helgaas Signed-off-by: Sasha Levin --- drivers/pci/probe.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index c5286b027f00..bdcad5e0f057 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -1890,9 +1890,6 @@ int pci_setup_device(struct pci_dev *dev) dev->broken_intx_masking = pci_intx_mask_broken(dev); - /* Clear errors left from system firmware */ - pci_write_config_word(dev, PCI_STATUS, 0xffff); - switch (dev->hdr_type) { /* header type */ case PCI_HEADER_TYPE_NORMAL: /* standard header */ if (class == PCI_CLASS_BRIDGE_PCI) -- 2.35.1