From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 018CD79C9 for ; Thu, 12 Jan 2023 14:22:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73A01C433EF; Thu, 12 Jan 2023 14:22:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1673533365; bh=tQVn55w7Wt6/30PlQhMXILgvwoWt1zq4OzmwmApRs44=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hAXNs4M9gqV0MLfhPScgnhdsSSXaviTVmwha+5dyGsbcWcllFBfj1js0D3+rRROuw osS5cwW31uzxo22/gcAPeIcqv8MB0sHIFNyHipLx9DI+qqDCnjTG2Z2nTONa4TQWyV lZX793Xid1tVLy5gRHgVBg7rI0xDe2lRZcDKd0Ek= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Janne Terho , Alexandre Belloni , Sasha Levin Subject: [PATCH 5.10 455/783] rtc: pcf85063: fix pcf85063_clkout_control Date: Thu, 12 Jan 2023 14:52:51 +0100 Message-Id: <20230112135545.339346649@linuxfoundation.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230112135524.143670746@linuxfoundation.org> References: <20230112135524.143670746@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Alexandre Belloni [ Upstream commit c2d12e85336f6d4172fb2bab5935027c446d7343 ] pcf85063_clkout_control reads the wrong register but then update the correct one. Reported-by: Janne Terho Fixes: 8c229ab6048b ("rtc: pcf85063: Add pcf85063 clkout control to common clock framework") Link: https://lore.kernel.org/r/20221211223553.59955-1-alexandre.belloni@bootlin.com Signed-off-by: Alexandre Belloni Signed-off-by: Sasha Levin --- drivers/rtc/rtc-pcf85063.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-pcf85063.c b/drivers/rtc/rtc-pcf85063.c index d739b0c965aa..449204d84c61 100644 --- a/drivers/rtc/rtc-pcf85063.c +++ b/drivers/rtc/rtc-pcf85063.c @@ -430,7 +430,7 @@ static int pcf85063_clkout_control(struct clk_hw *hw, bool enable) unsigned int buf; int ret; - ret = regmap_read(pcf85063->regmap, PCF85063_REG_OFFSET, &buf); + ret = regmap_read(pcf85063->regmap, PCF85063_REG_CTRL2, &buf); if (ret < 0) return ret; buf &= PCF85063_REG_CLKO_F_MASK; -- 2.35.1