patches.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: linux-mm@kvack.org, "Liam R. Howlett" <Liam.Howlett@oracle.com>
Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev,
	maple-tree@lists.infradead.org, Vlastimil Babka <vbabka@suse.cz>
Subject: [RFC 05/11] mm/mmap/vma_merge: use the proper vma pointer in case 4
Date: Fri, 24 Feb 2023 11:00:16 +0100	[thread overview]
Message-ID: <20230224100022.11268-6-vbabka@suse.cz> (raw)
In-Reply-To: <20230224100022.11268-1-vbabka@suse.cz>

Almost all cases now use the 'next' pointer for the vma following
the merged area, and the cases diagram shows it as XXXX. Case 4 is
different as it uses 'mid' and NNNN, so change it for consistency. No
functional change.

Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
---
 mm/mmap.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/mm/mmap.c b/mm/mmap.c
index 704afa278a98..1e4be7174964 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -851,9 +851,9 @@ can_vma_merge_after(struct vm_area_struct *vma, unsigned long vm_flags,
  * vma, PPPPPP is the prev vma specified, and NNNNNN the next vma after:
  *
  *     AAAA             AAAA                   AAAA
- *    PPPPPPNNNNNN    PPPPPPNNNNNN       PPPPPPNNNNNN
+ *    PPPPPPNNNNNN    PPPPPPXXXXXX       PPPPPPNNNNNN
  *    cannot merge    might become       might become
- *                    PPNNNNNNNNNN       PPPPPPPPPPNN
+ *                    PPXXXXXXXXXX       PPPPPPPPPPNN
  *    mmap, brk or    case 4 below       case 5 below
  *    mremap move:
  *                        AAAA               AAAA
@@ -972,9 +972,9 @@ struct vm_area_struct *vma_merge(struct vma_iterator *vmi, struct mm_struct *mm,
 		res = next;
 		if (prev && addr < prev->vm_end) {	/* case 4 */
 			vma_end = addr;
-			adjust = mid;
+			adjust = next;
 			adj_next = -(prev->vm_end - addr);
-			err = dup_anon_vma(mid, prev);
+			err = dup_anon_vma(next, prev);
 		} else {
 			vma = next;			/* case 3 */
 			vma_start = addr;
-- 
2.39.2


  parent reply	other threads:[~2023-02-24 10:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-24 10:00 [RFC 00/11] cleanup vma_merge and improve mergeability tests Vlastimil Babka
2023-02-24 10:00 ` [RFC 01/11] mm/mremap: fix dup_anon_vma() in vma_merge() case 4 Vlastimil Babka
2023-02-24 10:00 ` [RFC 02/11] mm/mmap/vma_merge: use only primary pointers for preparing merge Vlastimil Babka
2023-02-24 10:00 ` [RFC 03/11] mm/mmap/vma_merge: use the proper vma pointer in case 3 Vlastimil Babka
2023-02-24 10:00 ` [RFC 04/11] mm/mmap/vma_merge: use the proper vma pointers in cases 1 and 6 Vlastimil Babka
2023-02-24 10:00 ` Vlastimil Babka [this message]
2023-02-24 10:00 ` [RFC 06/11] mm/mmap/vma_merge: initialize mid and next in natural order Vlastimil Babka
2023-02-24 10:00 ` [RFC 07/11] mm/mmap/vma_merge: set mid to NULL if not applicable Vlastimil Babka
2023-02-24 10:00 ` [RFC 08/11] mm/mmap/vma_merge: rename adj_next to adj_start Vlastimil Babka
2023-02-24 10:00 ` [RFC 09/11] mm/mmap/vma_merge: convert mergeability checks to return bool Vlastimil Babka
2023-02-24 10:00 ` [RFC 10/11] mm/mmap: start distinguishing if vma can be removed in mergeability test Vlastimil Babka
2023-02-24 10:00 ` [RFC 11/11] mm/mremap: simplify vma expansion again Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230224100022.11268-6-vbabka@suse.cz \
    --to=vbabka@suse.cz \
    --cc=Liam.Howlett@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=maple-tree@lists.infradead.org \
    --cc=patches@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).