From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F211BBA48 for ; Tue, 7 Mar 2023 18:20:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F6D6C433D2; Tue, 7 Mar 2023 18:20:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1678213201; bh=GzmUm3VOWQdLobvHfaTyjwWRZiMDcuEDKxVev8MLmjg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Sno1R7KmkmV0clrW9xy7MfKVZdcDkr6p5faR+iM1FVUH3oy0U2GXsvbn7Eq/5T1w5 Plkw4w8Vv9/qyBfpjoOqGTdOM5y/PnXgpgZ+EWFIFBeAuibqQJbYv0td5yL8GKpEDi plr0tD0Y7fy/zjVoaqRxodojc3PM2dlBkHBLMxog= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Bartosz Golaszewski , Konrad Dybcio , Sasha Levin Subject: [PATCH 6.1 431/885] tty: serial: qcom-geni-serial: stop operations in progress at shutdown Date: Tue, 7 Mar 2023 17:56:05 +0100 Message-Id: <20230307170021.139332126@linuxfoundation.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230307170001.594919529@linuxfoundation.org> References: <20230307170001.594919529@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Bartosz Golaszewski [ Upstream commit d8aca2f96813d51df574a811eda9a2cbed00f261 ] We don't stop transmissions in progress at shutdown. This is fine with FIFO SE mode but with DMA (support for which we'll introduce later) it causes trouble so fix it now. Fixes: e83766334f96 ("tty: serial: qcom_geni_serial: No need to stop tx/rx on UART shutdown") Signed-off-by: Bartosz Golaszewski Reviewed-by: Konrad Dybcio Link: https://lore.kernel.org/r/20221229155030.418800-2-brgl@bgdev.pl Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/tty/serial/qcom_geni_serial.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c index 7905935b9f1b4..fd72644605e05 100644 --- a/drivers/tty/serial/qcom_geni_serial.c +++ b/drivers/tty/serial/qcom_geni_serial.c @@ -891,6 +891,8 @@ static int setup_fifos(struct qcom_geni_serial_port *port) static void qcom_geni_serial_shutdown(struct uart_port *uport) { disable_irq(uport->irq); + qcom_geni_serial_stop_tx(uport); + qcom_geni_serial_stop_rx(uport); } static int qcom_geni_serial_port_setup(struct uart_port *uport) -- 2.39.2