From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C089882C for ; Fri, 10 Mar 2023 15:16:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD2BCC433D2; Fri, 10 Mar 2023 15:16:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1678461371; bh=sI7Vzw2HWyJYJE3HrWAP/Fn2wxh8ry9jE7B8FVmBFxk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kbMcdCYSD8Xkm9H+KkuskTs70dhfhu86R12WFGO5dfOU6793IN3KApZny6GBi1hPK O2EjP7DhIx06dYNujXaYfVmgA/w7ouKSYKhP5vxIe0SGIpT+Hyb6KgwBhpoOAmfEEw ekPtrXFcvkfbdAB/acArXZ58qOelifugvzsG8G4U= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Nadav Amit , VMware PV-Drivers Reviewers , Arnd Bergmann , Sasha Levin Subject: [PATCH 5.15 115/136] misc: vmw_balloon: fix memory leak with using debugfs_lookup() Date: Fri, 10 Mar 2023 14:43:57 +0100 Message-Id: <20230310133710.693960578@linuxfoundation.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230310133706.811226272@linuxfoundation.org> References: <20230310133706.811226272@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Greg Kroah-Hartman [ Upstream commit 209cdbd07cfaa4b7385bad4eeb47e5ec1887d33d ] When calling debugfs_lookup() the result must have dput() called on it, otherwise the memory will leak over time. To make things simpler, just call debugfs_lookup_and_remove() instead which handles all of the logic at once. Cc: Nadav Amit Cc: VMware PV-Drivers Reviewers Cc: Arnd Bergmann Link: https://lore.kernel.org/r/20230202141100.2291188-1-gregkh@linuxfoundation.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/misc/vmw_balloon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c index f1d8ba6d48574..dab8ad9fed6b3 100644 --- a/drivers/misc/vmw_balloon.c +++ b/drivers/misc/vmw_balloon.c @@ -1711,7 +1711,7 @@ static void __init vmballoon_debugfs_init(struct vmballoon *b) static void __exit vmballoon_debugfs_exit(struct vmballoon *b) { static_key_disable(&balloon_stat_enabled.key); - debugfs_remove(debugfs_lookup("vmmemctl", NULL)); + debugfs_lookup_and_remove("vmmemctl", NULL); kfree(b->stats); b->stats = NULL; } -- 2.39.2