From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 349401C03 for ; Mon, 20 Mar 2023 15:00:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB2D4C433EF; Mon, 20 Mar 2023 15:00:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1679324448; bh=p/eMCVIC2JaQ3xgBMzOwPzRuLev4oq6rs3D8rJzDF54=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WENjbeHscnmFSqBjamad1JcDoRxReui+FksYVALjTqdEcMxGGU/VINoJjovUDLu6n pHhxByaQlJqYkGD6MxWr4Du7WTei7UWsMOetn7bTsBxpIs0fJ7tb9n+A2/8+iWruo9 TG9HqW9vJ7DQlIwZ3UHp0IsxT1MTuXAHksZyrjfI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Liang He , Jens Axboe , Sasha Levin Subject: [PATCH 5.4 27/60] block: sunvdc: add check for mdesc_grab() returning NULL Date: Mon, 20 Mar 2023 15:54:36 +0100 Message-Id: <20230320145432.044014920@linuxfoundation.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230320145430.861072439@linuxfoundation.org> References: <20230320145430.861072439@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Liang He [ Upstream commit 6030363199e3a6341afb467ddddbed56640cbf6a ] In vdc_port_probe(), we should check the return value of mdesc_grab() as it may return NULL, which can cause potential NPD bug. Fixes: 43fdf27470b2 ("[SPARC64]: Abstract out mdesc accesses for better MD update handling.") Signed-off-by: Liang He Link: https://lore.kernel.org/r/20230315062032.1741692-1-windhl@126.com [axboe: style cleanup] Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/block/sunvdc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/block/sunvdc.c b/drivers/block/sunvdc.c index 6b2fd630de852..6622dd1aa07b2 100644 --- a/drivers/block/sunvdc.c +++ b/drivers/block/sunvdc.c @@ -983,6 +983,8 @@ static int vdc_port_probe(struct vio_dev *vdev, const struct vio_device_id *id) print_version(); hp = mdesc_grab(); + if (!hp) + return -ENODEV; err = -ENODEV; if ((vdev->dev_no << PARTITION_SHIFT) & ~(u64)MINORMASK) { -- 2.39.2