From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A2BA5683 for ; Mon, 3 Apr 2023 14:19:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 162ABC433D2; Mon, 3 Apr 2023 14:19:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1680531559; bh=xzkDB1uiJ+7IJS1LEtEGwk+zR+KsCP8XTZubpVXtn+Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bYRSAzSODryORXY1YLr4b6TEMj+v9L578DKCYmjbqEopl2VgMtD9A68X/3z7hxFEh hbiPOF4lAuhIhrIo3NopeSmz4ft3Ix4CssrTBFj4RuDyYJdmQ7WshpkWpG0SuCiMMI vjznFLcBU3zrEJ/dnnPcBbfpQv6yTBLcJ0Rd64eA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Liang He , "David S. Miller" , Sasha Levin Subject: [PATCH 5.4 024/104] net: mdio: thunder: Add missing fwnode_handle_put() Date: Mon, 3 Apr 2023 16:08:16 +0200 Message-Id: <20230403140405.202496963@linuxfoundation.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230403140403.549815164@linuxfoundation.org> References: <20230403140403.549815164@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Liang He [ Upstream commit b1de5c78ebe9858ccec9d49af2f76724f1d47e3e ] In device_for_each_child_node(), we should add fwnode_handle_put() when break out of the iteration device_for_each_child_node() as it will automatically increase and decrease the refcounter. Fixes: 379d7ac7ca31 ("phy: mdio-thunder: Add driver for Cavium Thunder SoC MDIO buses.") Signed-off-by: Liang He Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/phy/mdio-thunder.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/phy/mdio-thunder.c b/drivers/net/phy/mdio-thunder.c index 1e2f57ed1ef75..31ca0361a11e0 100644 --- a/drivers/net/phy/mdio-thunder.c +++ b/drivers/net/phy/mdio-thunder.c @@ -104,6 +104,7 @@ static int thunder_mdiobus_pci_probe(struct pci_dev *pdev, if (i >= ARRAY_SIZE(nexus->buses)) break; } + fwnode_handle_put(fwn); return 0; err_release_regions: -- 2.39.2