From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A18F66FA1 for ; Mon, 3 Apr 2023 14:39:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 294B2C4339B; Mon, 3 Apr 2023 14:39:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1680532784; bh=yaYpCtLRfmjUuIvNWvHTFxbYboZFUz5YJPZyLEtAs1c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PuX4wx7P+C5ENnKIf/m4GjrOgkhOjtJo3+GGGMOEACZS9gXCoyMr7HV351pPkhBQw /MqhWpy0CkDIxDqlNo52gDE871oKI2wvPSkAmg/hgHW1wYy8kBf7Xr0BTyqjw7gFWP zCRiWK/JrmvSVClmX9iCEaDa3z4NU10AK7Jqiy2I= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Pavan Chebbi , Somnath Kotur , Kalesh AP , Michael Chan , Simon Horman , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.1 114/181] bnxt_en: Fix reporting of test result in ethtool selftest Date: Mon, 3 Apr 2023 16:09:09 +0200 Message-Id: <20230403140418.804293319@linuxfoundation.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230403140415.090615502@linuxfoundation.org> References: <20230403140415.090615502@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Kalesh AP [ Upstream commit 83714dc3db0e4a088673601bc8099b079bc1a077 ] When the selftest command fails, driver is not reporting the failure by updating the "test->flags" when bnxt_close_nic() fails. Fixes: eb51365846bc ("bnxt_en: Add basic ethtool -t selftest support.") Reviewed-by: Pavan Chebbi Reviewed-by: Somnath Kotur Signed-off-by: Kalesh AP Signed-off-by: Michael Chan Reviewed-by: Simon Horman Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c index 703fc163235f9..cdbc62ad659cb 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c @@ -3634,6 +3634,7 @@ static void bnxt_self_test(struct net_device *dev, struct ethtool_test *etest, bnxt_ulp_stop(bp); rc = bnxt_close_nic(bp, true, false); if (rc) { + etest->flags |= ETH_TEST_FL_FAILED; bnxt_ulp_start(bp, rc); return; } -- 2.39.2