From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pratyush Yadav <ptyadav@amazon.de>
Cc: Steve French <stfrench@microsoft.com>,
Amir Goldstein <amir73il@gmail.com>,
Aurelien Aptel <aaptel@suse.com>,
stable@vger.kernel.org, patches@lists.linux.dev,
Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 5.4] smb3: fix problem with null cifs super block with previous patch
Date: Wed, 5 Apr 2023 16:20:40 +0200 [thread overview]
Message-ID: <2023040523-delusion-corrode-f466@gregkh> (raw)
In-Reply-To: <20230405135709.100174-1-ptyadav@amazon.de>
On Wed, Apr 05, 2023 at 03:57:09PM +0200, Pratyush Yadav wrote:
> From: Steve French <stfrench@microsoft.com>
>
> [ Upstream commit 87f93d82e0952da18af4d978e7d887b4c5326c0b ]
>
> Add check for null cifs_sb to create_options helper
>
> Signed-off-by: Steve French <stfrench@microsoft.com>
> Reviewed-by: Amir Goldstein <amir73il@gmail.com>
> Reviewed-by: Aurelien Aptel <aaptel@suse.com>
> Signed-off-by: Pratyush Yadav <ptyadav@amazon.de>
> ---
>
> Only compile-tested. This was discovered by our static code analysis
> tool. I do not use CIFS and do not know how to actually reproduce the
> NULL dereference.
>
> Follow up from [0]. Original patch is at [1].
>
> Mandatory text due to licensing terms:
>
> This bug was discovered and resolved using Coverity Static Analysis
> Security Testing (SAST) by Synopsys, Inc.
What? That's funny. And nothing I'm going to be adding to the
changelog text, sorry, as that's not what is upstream. Please go poke
your lawyers, that's not ok.
thanks,
greg k-h
next prev parent reply other threads:[~2023-04-05 14:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 13:57 [PATCH 5.4] smb3: fix problem with null cifs super block with previous patch Pratyush Yadav
2023-04-05 14:20 ` Greg Kroah-Hartman [this message]
2023-04-05 14:34 ` Pratyush Yadav
2023-04-05 17:04 ` Greg Kroah-Hartman
2023-04-06 8:48 ` Pratyush Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023040523-delusion-corrode-f466@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=aaptel@suse.com \
--cc=amir73il@gmail.com \
--cc=patches@lists.linux.dev \
--cc=ptyadav@amazon.de \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=stfrench@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox