From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 095F8168B4 for ; Mon, 8 May 2023 09:53:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 80305C4339B; Mon, 8 May 2023 09:53:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1683539632; bh=kV535IjRdJ0A0vUdfE3JL7tDOZ55ruz5VTsPZCAAS40=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vNuJmm3oTnlZBHxjixWCr2UmBsPgJRvUz30G7gfacOf9JX32CshK8BoV9Qh6cv4Uj DzE57xFM5CQhtGg35uUFzwvPBo64RMX0+vpRCAmr4vDAHNjgDvAwYKMCHrVsDISO1B 8gYHA0x3fKnrDYfmZQyGFoXQIXqEf3pLKWdY08kE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Namjae Jeon , Steve French , zdi-disclosures@trendmicro.com Subject: [PATCH 6.1 088/611] ksmbd: call rcu_barrier() in ksmbd_server_exit() Date: Mon, 8 May 2023 11:38:50 +0200 Message-Id: <20230508094425.006724132@linuxfoundation.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230508094421.513073170@linuxfoundation.org> References: <20230508094421.513073170@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Namjae Jeon commit eb307d09fe15844fdaebeb8cc8c9b9e925430aa5 upstream. racy issue is triggered the bug by racing between closing a connection and rmmod. In ksmbd, rcu_barrier() is not called at module unload time, so nothing prevents ksmbd from getting unloaded while it still has RCU callbacks pending. It leads to trigger unintended execution of kernel code locally and use to defeat protections such as Kernel Lockdown Cc: stable@vger.kernel.org Reported-by: zdi-disclosures@trendmicro.com # ZDI-CAN-20477 Signed-off-by: Namjae Jeon Signed-off-by: Steve French Signed-off-by: Greg Kroah-Hartman --- fs/ksmbd/server.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/ksmbd/server.c +++ b/fs/ksmbd/server.c @@ -614,6 +614,7 @@ err_unregister: static void __exit ksmbd_server_exit(void) { ksmbd_server_shutdown(); + rcu_barrier(); ksmbd_release_inode_hash(); }