From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2FD1168C2 for ; Mon, 8 May 2023 10:22:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 554F7C433EF; Mon, 8 May 2023 10:22:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1683541337; bh=0VbnlVJjOo638DvmnajlggrGbUsglIz0Kltuz/fFdL0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RLBSrPGzNzkBOPyW2j3RfBxrm6U8Hv/FEhA4NArYzQ6B1N/OKzA14tDjXUrSohmxM SSeUmb9QsBu0u3XeXu71QoGxDUDCH5ga3cmniriPzOQvqL9uwtO/Lu6u/pCOttTiDY TtKLcBNKe5sBo6AbuyrAD0ldWVBX38aA2g9rUprk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Krzysztof Kozlowski , Konrad Dybcio , Vinod Koul Subject: [PATCH 6.2 065/663] soundwire: qcom: correct setting ignore bit on v1.5.1 Date: Mon, 8 May 2023 11:38:11 +0200 Message-Id: <20230508094430.586951932@linuxfoundation.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230508094428.384831245@linuxfoundation.org> References: <20230508094428.384831245@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Krzysztof Kozlowski commit bd934f77eeac377e81ddac8673803e7334b82d3d upstream. According to the comment and to downstream sources, the SWRM_CONTINUE_EXEC_ON_CMD_IGNORE in SWRM_CMD_FIFO_CFG_ADDR register should be set for v1.5.1 and newer, so fix the >= operator. Fixes: 542d3491cdd7 ("soundwire: qcom: set continue execution flag for ignored commands") Cc: Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio Link: https://lore.kernel.org/r/20230222140343.188691-1-krzysztof.kozlowski@linaro.org Signed-off-by: Vinod Koul Signed-off-by: Greg Kroah-Hartman --- drivers/soundwire/qcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/soundwire/qcom.c +++ b/drivers/soundwire/qcom.c @@ -704,7 +704,7 @@ static int qcom_swrm_init(struct qcom_sw } /* Configure number of retries of a read/write cmd */ - if (ctrl->version > 0x01050001) { + if (ctrl->version >= 0x01050001) { /* Only for versions >= 1.5.1 */ ctrl->reg_write(ctrl, SWRM_CMD_FIFO_CFG_ADDR, SWRM_RD_WR_CMD_RETRIES |