From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 437DE11198 for ; Mon, 15 May 2023 17:59:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A0C7C4339B; Mon, 15 May 2023 17:59:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1684173599; bh=0MwHXMfPnN8rWQPM8Vs44rwICRf8fgsWRyCXOyRWrz8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WWsLduEvidKIG7jvQGXMEpH9hCvhqfCN5dmtyitpYhgaiR24Z6jnBbO9X3jNekSq6 4zdhURwAccx48UgKJMvx+14M+U9IiYbUnCPAZGauA16EBKmCHSEfsgCM7G/3c57JiU VVLQlNSTU63lYpNkuTJunWoSOziBI9KFdqwxWDvs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dongliang Mu , Peter Chen , Yinhao Hu , Sasha Levin Subject: [PATCH 5.4 147/282] usb: chipidea: fix missing goto in `ci_hdrc_probe` Date: Mon, 15 May 2023 18:28:45 +0200 Message-Id: <20230515161726.624449027@linuxfoundation.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230515161722.146344674@linuxfoundation.org> References: <20230515161722.146344674@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Yinhao Hu [ Upstream commit d6f712f53b79f5017cdcefafb7a5aea9ec52da5d ] >>From the comment of ci_usb_phy_init, it returns an error code if usb_phy_init has failed, and it should do some clean up, not just return directly. Fix this by goto the error handling. Fixes: 74475ede784d ("usb: chipidea: move PHY operation to core") Reviewed-by: Dongliang Mu Acked-by: Peter Chen Signed-off-by: Yinhao Hu Link: https://lore.kernel.org/r/20230412055852.971991-1-dddddd@hust.edu.cn Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/chipidea/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index 7a86979cf1406..27298ca083d14 100644 --- a/drivers/usb/chipidea/core.c +++ b/drivers/usb/chipidea/core.c @@ -1084,7 +1084,7 @@ static int ci_hdrc_probe(struct platform_device *pdev) ret = ci_usb_phy_init(ci); if (ret) { dev_err(dev, "unable to init phy: %d\n", ret); - return ret; + goto ulpi_exit; } ci->hw_bank.phys = res->start; -- 2.39.2