From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4070D1772F for ; Mon, 15 May 2023 18:01:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98B97C433D2; Mon, 15 May 2023 18:01:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1684173708; bh=iyJuJzaFG49nd/WlcG0bPHlJ9D8zDCOWs63HpxlQM00=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mFyvZ3HfL5HbUDe0mRy+t1eP9BZn1wKLKMcrGBp8H4C8eq3kxGlX+zzSWqMKZoHZG ezgTe9ddQR1cQKyWvViLa2V3fK70VufBhSNvdxiED5L5vJbjfY+JMhCmJnHfHn/wi/ HQib68WyVurEDFZVHWldnM/fSD1IiQKHFKlZdZ7M= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Randy Dunlap , Pavel Machek , Lee Jones , Sasha Levin Subject: [PATCH 5.4 182/282] leds: TI_LMU_COMMON: select REGMAP instead of depending on it Date: Mon, 15 May 2023 18:29:20 +0200 Message-Id: <20230515161727.731112432@linuxfoundation.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230515161722.146344674@linuxfoundation.org> References: <20230515161722.146344674@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Randy Dunlap [ Upstream commit a61079efc87888587e463afaed82417b162fbd69 ] REGMAP is a hidden (not user visible) symbol. Users cannot set it directly thru "make *config", so drivers should select it instead of depending on it if they need it. Consistently using "select" or "depends on" can also help reduce Kconfig circular dependency issues. Therefore, change the use of "depends on REGMAP" to "select REGMAP". Fixes: 3fce8e1eb994 ("leds: TI LMU: Add common code for TI LMU devices") Signed-off-by: Randy Dunlap Acked-by: Pavel Machek Signed-off-by: Lee Jones Link: https://lore.kernel.org/r/20230226053953.4681-5-rdunlap@infradead.org Signed-off-by: Sasha Levin --- drivers/leds/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index 2cbf66d1c3000..34334adcad014 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -802,7 +802,7 @@ config LEDS_SPI_BYTE config LEDS_TI_LMU_COMMON tristate "LED driver for TI LMU" depends on LEDS_CLASS - depends on REGMAP + select REGMAP help Say Y to enable the LED driver for TI LMU devices. This supports common features between the TI LM3532, LM3631, LM3632, -- 2.39.2