From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 634C7171A9 for ; Mon, 22 May 2023 19:34:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CFA28C433D2; Mon, 22 May 2023 19:34:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1684784082; bh=qhbOK6fI3RUsD3s2Q+BB078Hdq4q8lEbKfKsd1/52X8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lrLBALYzmTY6eRBlG7wc6SVoCRP9vhpwD5XyEyhoNlcU5rhycB9UyFfC6TV0s3X4P soxhYTcjQZXae5LE9NVZHL5P2UwhetDH3HE2GIt6b1E8Nia/lcxVCZ9NpKDSOpEVEZ uc4qzGODSnVMJKQyzHvKDWGZdHjUX9KORu+HdTMU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Chih-Yen Chang , Namjae Jeon , Steve French Subject: [PATCH 6.1 257/292] ksmbd: allocate one more byte for implied bcc[0] Date: Mon, 22 May 2023 20:10:14 +0100 Message-Id: <20230522190412.368305831@linuxfoundation.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230522190405.880733338@linuxfoundation.org> References: <20230522190405.880733338@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Chih-Yen Chang commit 443d61d1fa9faa60ef925513d83742902390100f upstream. ksmbd_smb2_check_message allows client to return one byte more, so we need to allocate additional memory in ksmbd_conn_handler_loop to avoid out-of-bound access. Cc: stable@vger.kernel.org Signed-off-by: Chih-Yen Chang Acked-by: Namjae Jeon Signed-off-by: Steve French Signed-off-by: Greg Kroah-Hartman --- fs/ksmbd/connection.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/fs/ksmbd/connection.c +++ b/fs/ksmbd/connection.c @@ -353,7 +353,8 @@ int ksmbd_conn_handler_loop(void *p) break; /* 4 for rfc1002 length field */ - size = pdu_size + 4; + /* 1 for implied bcc[0] */ + size = pdu_size + 4 + 1; conn->request_buf = kvmalloc(size, GFP_KERNEL); if (!conn->request_buf) break;