From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AEA18F6D for ; Sun, 16 Jul 2023 20:23:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0FECC433C7; Sun, 16 Jul 2023 20:23:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1689539019; bh=C0xkU8zMyJ2RmmLy32ucEI2jbZBJp14vEhOEqQbKIJ4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Uzm8LZ6dMgsDBal5jWd0bmPo3+jYZr6XDFLrFpIjqTD4yGiLopy3xfnrJhwYoZSWh 95RM7q2KCfyVfCWsz8hpIQSQ52dZM5PNYmjqXCKGMnQAUzkuZXacVbRwEjPnMfltoo GSJYo2RDn+bakjt4XXqADpGVOpOr3wJSlX2uOok0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Nipun Gupta , Alex Williamson , Nikhil Agarwal , Sasha Levin Subject: [PATCH 6.4 628/800] cdx: fix driver managed dma support Date: Sun, 16 Jul 2023 21:48:01 +0200 Message-ID: <20230716195003.698272180@linuxfoundation.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230716194949.099592437@linuxfoundation.org> References: <20230716194949.099592437@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Nipun Gupta [ Upstream commit b8c5ff76059ded3758de3db83e04189a072ac01f ] The devices on cdx could be bound to drivers with the device DMA managed by kernel drivers or user-space applications. As multiple devices can be placed in the same IOMMU group, the DMA on these devices must either be entirely under kernel control or userspace control. Fix the CDX bus driver to acknowlege the driver_managed_dma flag and call the appropriate iommu APIs. Fixes: 2959ab247061 ("cdx: add the cdx bus driver") Signed-off-by: Nipun Gupta Reported-by: Alex Williamson Closes: https://lore.kernel.org/lkml/20230524134831.28dc97e2.alex.williamson@redhat.com/ Reviewed-by: Nikhil Agarwal Message-ID: <20230605131009.6869-1-nipun.gupta@amd.com> Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/cdx/cdx.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/drivers/cdx/cdx.c b/drivers/cdx/cdx.c index 38511fd363257..d2cad4c670a07 100644 --- a/drivers/cdx/cdx.c +++ b/drivers/cdx/cdx.c @@ -62,6 +62,8 @@ #include #include #include +#include +#include #include "cdx.h" /* Default DMA mask for devices on a CDX bus */ @@ -257,6 +259,7 @@ static void cdx_shutdown(struct device *dev) static int cdx_dma_configure(struct device *dev) { + struct cdx_driver *cdx_drv = to_cdx_driver(dev->driver); struct cdx_device *cdx_dev = to_cdx_device(dev); u32 input_id = cdx_dev->req_id; int ret; @@ -267,9 +270,23 @@ static int cdx_dma_configure(struct device *dev) return ret; } + if (!ret && !cdx_drv->driver_managed_dma) { + ret = iommu_device_use_default_domain(dev); + if (ret) + arch_teardown_dma_ops(dev); + } + return 0; } +static void cdx_dma_cleanup(struct device *dev) +{ + struct cdx_driver *cdx_drv = to_cdx_driver(dev->driver); + + if (!cdx_drv->driver_managed_dma) + iommu_device_unuse_default_domain(dev); +} + /* show configuration fields */ #define cdx_config_attr(field, format_string) \ static ssize_t \ @@ -405,6 +422,7 @@ struct bus_type cdx_bus_type = { .remove = cdx_remove, .shutdown = cdx_shutdown, .dma_configure = cdx_dma_configure, + .dma_cleanup = cdx_dma_cleanup, .bus_groups = cdx_bus_groups, .dev_groups = cdx_dev_groups, }; -- 2.39.2