From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01F591ED41 for ; Fri, 21 Jul 2023 18:51:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 78171C433C8; Fri, 21 Jul 2023 18:51:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1689965482; bh=jR9aMMNgsl3xWtwYY47AqPgStgMVxHerlfx8HNGOOMw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yCgRClwBk2dv0EUln3Z4seAsLCklVljq0owRB0aCCoTdvIsFqo7X0mu0UlBPu7Lqz 4PQH762GIz3HKRxf0HxFMef9ZTcDu2+RJHS2KpiPEzldJCuOx969vd+t2REHsB40nQ WMbP2Bw0qfU5ddbnjHRODTwcq9C7y079ZhiQMceE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dan Carpenter , "Martin K. Petersen" Subject: [PATCH 6.4 289/292] scsi: qla2xxx: Fix end of loop test Date: Fri, 21 Jul 2023 18:06:38 +0200 Message-ID: <20230721160541.375489163@linuxfoundation.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230721160528.800311148@linuxfoundation.org> References: <20230721160528.800311148@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Dan Carpenter commit 339020091e246e708c1381acf74c5f8e3fe4d2b5 upstream. This loop will exit successfully when "found" is false or in the failure case it times out with "wait_iter" set to -1. The test for timeouts is impossible as is. Fixes: b843adde8d49 ("scsi: qla2xxx: Fix mem access after free") Signed-off-by: Dan Carpenter Link: https://lore.kernel.org/r/cea5a62f-b873-4347-8f8e-c67527ced8d2@kili.mountain Signed-off-by: Martin K. Petersen Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/qla2xxx/qla_os.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c @@ -1409,7 +1409,7 @@ __qla2x00_eh_wait_for_pending_commands(s break; } - if (!wait_iter && found) + if (wait_iter == -1) status = QLA_FUNCTION_FAILED; return status;