From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CA961ED4F for ; Tue, 25 Jul 2023 11:37:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1D7FC433C9; Tue, 25 Jul 2023 11:37:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1690285047; bh=DFwmuwOqmFlNw5XS/YYwc3XVWXfYS+0BLV9iRlod+/k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GGfuG2OA5rD1FOrrIXgN58JZC+EcbDkowxRE/1WVNqRcN+AT83GKcM+RL3/6sNqgm 7c/72mEIH32RXWw2A4ewF2ItQLeKQ5et4nr1TiHf5o35EMIzVOnXLyMWKjt4Bjis2s UgVudVS5ZbGDfIH+/rorWbOpT8VXtJTlj0JqKzGI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jiasheng Jiang , Kees Cook , Sasha Levin Subject: [PATCH 5.4 026/313] pstore/ram: Add check for kstrdup Date: Tue, 25 Jul 2023 12:42:59 +0200 Message-ID: <20230725104522.248301179@linuxfoundation.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230725104521.167250627@linuxfoundation.org> References: <20230725104521.167250627@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Jiasheng Jiang [ Upstream commit d97038d5ec2062733c1e016caf9baaf68cf64ea1 ] Add check for the return value of kstrdup() and return the error if it fails in order to avoid NULL pointer dereference. Fixes: e163fdb3f7f8 ("pstore/ram: Regularize prz label allocation lifetime") Signed-off-by: Jiasheng Jiang Signed-off-by: Kees Cook Link: https://lore.kernel.org/r/20230614093733.36048-1-jiasheng@iscas.ac.cn Signed-off-by: Sasha Levin --- fs/pstore/ram_core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/pstore/ram_core.c b/fs/pstore/ram_core.c index 286340f312dcb..73aed51447b9a 100644 --- a/fs/pstore/ram_core.c +++ b/fs/pstore/ram_core.c @@ -579,6 +579,8 @@ struct persistent_ram_zone *persistent_ram_new(phys_addr_t start, size_t size, raw_spin_lock_init(&prz->buffer_lock); prz->flags = flags; prz->label = kstrdup(label, GFP_KERNEL); + if (!prz->label) + goto err; ret = persistent_ram_buffer_map(start, size, prz, memtype); if (ret) -- 2.39.2