From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F67D1ED4F for ; Tue, 25 Jul 2023 11:40:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5667C433C7; Tue, 25 Jul 2023 11:40:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1690285255; bh=jJENnagmG4Tojdxk5zaYe9j3NipEVV+opXoZGc6K04g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OJMhHWAxwWTQa8jpjKzJsUY2vOKEfaaAd873eOoI7FYp8Tu++Wi7ejKZ0h1qt+Fi3 hhwoXs53DfpotYvOGrrvjoY4bDl3C2Lqs/qtOvEGj2/PQVUWPFyHWBUr8KkZddBY2Z OnlGwB2IxHePWVh5eA0pEdWjmhVK2WAE6eW6knHs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Amelie Delaunay , Lee Jones , Sasha Levin Subject: [PATCH 5.4 140/313] mfd: stmfx: Fix error path in stmfx_chip_init Date: Tue, 25 Jul 2023 12:44:53 +0200 Message-ID: <20230725104527.059763991@linuxfoundation.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230725104521.167250627@linuxfoundation.org> References: <20230725104521.167250627@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Amelie Delaunay [ Upstream commit f592cf624531286f8b52e40dcfc157a5a7fb115c ] In error path, disable vdd regulator if it exists, but don't overload ret. Because if regulator_disable() is successful, stmfx_chip_init will exit successfully while chip init failed. Fixes: 06252ade9156 ("mfd: Add ST Multi-Function eXpander (STMFX) core driver") Signed-off-by: Amelie Delaunay Link: https://lore.kernel.org/r/20230609092804.793100-1-amelie.delaunay@foss.st.com Signed-off-by: Lee Jones Signed-off-by: Sasha Levin --- drivers/mfd/stmfx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/stmfx.c b/drivers/mfd/stmfx.c index 711979afd90a0..887c92342b7f1 100644 --- a/drivers/mfd/stmfx.c +++ b/drivers/mfd/stmfx.c @@ -389,7 +389,7 @@ static int stmfx_chip_init(struct i2c_client *client) err: if (stmfx->vdd) - return regulator_disable(stmfx->vdd); + regulator_disable(stmfx->vdd); return ret; } -- 2.39.2