From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 202F31ED4D for ; Tue, 25 Jul 2023 11:41:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 990FDC433C7; Tue, 25 Jul 2023 11:41:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1690285286; bh=rLe7xq0HybqXDCmzBHU7sf8wkOUW/s4pNG2qHRw5yCU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZsqEPLTDJ5vIP9PwUGfTeF34SdJczaRdO76snKKD/2LrCgrlosCavCLptGeIUrof6 JhcmThvgVi2CNLssryVP/hby4V1kkupq0uJ60GE1B202INt/jhelKm51JttUQT652g WCZIrj5Quj1izU2r1WVYMPd/Pw46jyRCLuBDk/5I= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Chao Yu , Jaegeuk Kim , Sasha Levin Subject: [PATCH 5.4 150/313] f2fs: fix error path handling in truncate_dnode() Date: Tue, 25 Jul 2023 12:45:03 +0200 Message-ID: <20230725104527.495714774@linuxfoundation.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230725104521.167250627@linuxfoundation.org> References: <20230725104521.167250627@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Chao Yu [ Upstream commit 0135c482fa97e2fd8245cb462784112a00ed1211 ] If truncate_node() fails in truncate_dnode(), it missed to call f2fs_put_page(), fix it. Fixes: 7735730d39d7 ("f2fs: fix to propagate error from __get_meta_page()") Signed-off-by: Chao Yu Signed-off-by: Jaegeuk Kim Signed-off-by: Sasha Levin --- fs/f2fs/node.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index b080d5c58f6cb..8256a2dedae8c 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -889,8 +889,10 @@ static int truncate_dnode(struct dnode_of_data *dn) dn->ofs_in_node = 0; f2fs_truncate_data_blocks(dn); err = truncate_node(dn); - if (err) + if (err) { + f2fs_put_page(page, 1); return err; + } return 1; } -- 2.39.2