From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A06FF1ED4F for ; Tue, 25 Jul 2023 11:44:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B798CC433C7; Tue, 25 Jul 2023 11:44:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1690285468; bh=7sKRCpSiq9DF4eaMajC9fn6H0qZBDje36+lgPRGi/W4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L9tnVhlFkD3WOLnos4Uytk7HEpAVFUZPmAn3LWIAPIT1viexnRubq2ShLIOf0Eg0g c7FqO57D+mCXnbxtQmzSo4L7JSfg83+e0eaMYWqzjizk1Auu3pQyGL92NhYA9lju9i TKjQ7U7xfPH26djtnwMdmu4LtetlqHLrVDU9X5EQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org, netfilter-devel@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Florian Westphal , Pablo Neira Ayuso Subject: [PATCH 5.4 188/313] netfilter: nf_tables: fix scheduling-while-atomic splat Date: Tue, 25 Jul 2023 12:45:41 +0200 Message-ID: <20230725104529.099642450@linuxfoundation.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230725104521.167250627@linuxfoundation.org> References: <20230725104521.167250627@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Florian Westphal [ 2024439bd5ceb145eeeb428b2a59e9b905153ac3 ] nf_tables_check_loops() can be called from rhashtable list walk so cond_resched() cannot be used here. Fixes: 81ea01066741 ("netfilter: nf_tables: add rescheduling points during loop detection walks") Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso Signed-off-by: Greg Kroah-Hartman --- net/netfilter/nf_tables_api.c | 4 ---- 1 file changed, 4 deletions(-) --- a/net/netfilter/nf_tables_api.c +++ b/net/netfilter/nf_tables_api.c @@ -7428,13 +7428,9 @@ static int nf_tables_check_loops(const s break; } } - - cond_resched(); } list_for_each_entry(set, &ctx->table->sets, list) { - cond_resched(); - if (!nft_is_active_next(ctx->net, set)) continue; if (!(set->flags & NFT_SET_MAP) ||