From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 524521ED38 for ; Tue, 25 Jul 2023 11:13:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA342C433C7; Tue, 25 Jul 2023 11:13:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1690283607; bh=zsZxocKI36DafTHxeSlxUIHV3nHxdnyvaE6BF5ZuKBg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Mkc3UcWk5vILj055lXRkr6/V2S1OHn6Rm9NSqNZmgUlTJvAHanbG8cgbPkg2OjOoe 68Ezwvop7Dy08TAtRw5FDM3iYAmuceu1O5R+aoyZLyfiddJXZk63GpGP3I8kt7qJ5G Qcz0FLEmnGf7aMHfXcxM8QwDXVqxtjOMpTlVmL+w= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Niklas Neronin , Tero Kristo , "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 5.10 029/509] cpufreq: intel_pstate: Fix energy_performance_preference for passive Date: Tue, 25 Jul 2023 12:39:28 +0200 Message-ID: <20230725104554.986897126@linuxfoundation.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230725104553.588743331@linuxfoundation.org> References: <20230725104553.588743331@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Tero Kristo [ Upstream commit 03f44ffb3d5be2fceda375d92c70ab6de4df7081 ] If the intel_pstate driver is set to passive mode, then writing the same value to the energy_performance_preference sysfs twice will fail. This is caused by the wrong return value used (index of the matched energy_perf_string), instead of the length of the passed in parameter. Fix by forcing the internal return value to zero when the same preference is passed in by user. This same issue is not present when active mode is used for the driver. Fixes: f6ebbcf08f37 ("cpufreq: intel_pstate: Implement passive mode with HWP enabled") Reported-by: Niklas Neronin Signed-off-by: Tero Kristo Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/cpufreq/intel_pstate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c index 1686705bee7bd..4b06b81d8bb0a 100644 --- a/drivers/cpufreq/intel_pstate.c +++ b/drivers/cpufreq/intel_pstate.c @@ -777,6 +777,8 @@ static ssize_t store_energy_performance_preference( err = cpufreq_start_governor(policy); if (!ret) ret = err; + } else { + ret = 0; } } -- 2.39.2