From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85B621ED38 for ; Tue, 25 Jul 2023 11:33:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AEB03C433C7; Tue, 25 Jul 2023 11:33:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1690284791; bh=u8kMrIeRfJJX8F7XcqjCgtxRft5l2WZVTAUQXf4w75Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yY2vMnZVmpX9ClZwNl1CyvucEUu+yDsQKMYzyooi4k0beJNgncFWXSSZ91Q+jl2hS 0SLy+CK9Hf10kZOFHadxqHXM8FoEWSvr+si5jV4x65/I+7eoxPg3m/5q3bdaOi6fyr Il9H/ch4fhFdU7vKWbVRgZe54bz1zBlQ8Aff/8O0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Wang Ming , Tariq Toukan , Kuniyuki Iwashima , "David S. Miller" , Sasha Levin Subject: [PATCH 5.10 483/509] net: ipv4: Use kfree_sensitive instead of kfree Date: Tue, 25 Jul 2023 12:47:02 +0200 Message-ID: <20230725104615.863343015@linuxfoundation.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230725104553.588743331@linuxfoundation.org> References: <20230725104553.588743331@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Wang Ming [ Upstream commit daa751444fd9d4184270b1479d8af49aaf1a1ee6 ] key might contain private part of the key, so better use kfree_sensitive to free it. Fixes: 38320c70d282 ("[IPSEC]: Use crypto_aead and authenc in ESP") Signed-off-by: Wang Ming Reviewed-by: Tariq Toukan Reviewed-by: Kuniyuki Iwashima Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/ipv4/esp4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/esp4.c b/net/ipv4/esp4.c index 20d7381378418..28252029bd798 100644 --- a/net/ipv4/esp4.c +++ b/net/ipv4/esp4.c @@ -1134,7 +1134,7 @@ static int esp_init_authenc(struct xfrm_state *x) err = crypto_aead_setkey(aead, key, keylen); free_key: - kfree(key); + kfree_sensitive(key); error: return err; -- 2.39.2