From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 426421ED38 for ; Tue, 25 Jul 2023 11:33:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB739C433C7; Tue, 25 Jul 2023 11:33:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1690284822; bh=VDce9/O6/Nb2vslHENbVXD/CwRk4e7GR8lqEDzkm6q0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xlHqrGjvhmIzpNZ3zXuGq3pY2Fm/e2pP8zIg6Gz4KIafIY7ppsZJVJIRRsRQyL9v5 FVou8XTSOky6turtZY+Zglg7Q8BHwrwQ3yt16RMcyixeDrwhemfwEPU6EAo5Bc5Aq5 3Dtw7XCTBfrnesQ3Lvqv/py4aC9q8WABdYp9q2FQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Eric Dumazet , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 493/509] tcp: annotate data-races around tp->tcp_tx_delay Date: Tue, 25 Jul 2023 12:47:12 +0200 Message-ID: <20230725104616.326348404@linuxfoundation.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230725104553.588743331@linuxfoundation.org> References: <20230725104553.588743331@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Eric Dumazet [ Upstream commit 348b81b68b13ebd489a3e6a46aa1c384c731c919 ] do_tcp_getsockopt() reads tp->tcp_tx_delay while another cpu might change its value. Fixes: a842fe1425cb ("tcp: add optional per socket transmit delay") Signed-off-by: Eric Dumazet Link: https://lore.kernel.org/r/20230719212857.3943972-2-edumazet@google.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/ipv4/tcp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index cc42ceadc1127..39919d1436cea 100644 --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c @@ -3447,7 +3447,7 @@ static int do_tcp_setsockopt(struct sock *sk, int level, int optname, case TCP_TX_DELAY: if (val) tcp_enable_tx_delay(); - tp->tcp_tx_delay = val; + WRITE_ONCE(tp->tcp_tx_delay, val); break; default: err = -ENOPROTOOPT; @@ -3902,7 +3902,7 @@ static int do_tcp_getsockopt(struct sock *sk, int level, break; case TCP_TX_DELAY: - val = tp->tcp_tx_delay; + val = READ_ONCE(tp->tcp_tx_delay); break; case TCP_TIMESTAMP: -- 2.39.2