From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA3A221D5D for ; Tue, 25 Jul 2023 16:13:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1912BC433C7; Tue, 25 Jul 2023 16:13:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690301625; bh=pA6OkiGQ+L6zB+DkGYGhgcqo0H9GLDXi4G7aQNpHWEE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L8F+k6yL95qjEOtSRSatYMaRUVi+5eNUAKOVxlSCsnQwCHl1BFDpxqC0dIURr7pge QNt0Ddn16O+nSqVYu9Ev+7qg+1TqWC8NZucEm9TlSSpH4K631ZOf1AsQFSjRAOHwB9 LaqquOy2KT1jzRiu+GTKpi9TH6HX/Qyf7uKy72Z5T0RAprm5wYzCwYgV1kHQUct+KH X0/cow+60LU6GGYXRY+fIxqpNQ2Miy8kc4KQ6741uCbiDfYwvffcptB6WTTV2rACdD CV1cADUJdIZgS5dceFQdqZYAGBqTp4rQaE95Lxh4LRI8Ql+i9f9zhGTwYEa0UVoetx nksdvzbx6FBNw== Date: Tue, 25 Jul 2023 09:13:43 -0700 From: Eric Biggers To: Greg Kroah-Hartman Cc: stable@vger.kernel.org, patches@lists.linux.dev, Herbert Xu , Sasha Levin Subject: Re: [PATCH 5.4 113/313] crypto: skcipher - unify the crypto_has_skcipher*() functions Message-ID: <20230725161343.GA2295@sol.localdomain> References: <20230725104521.167250627@linuxfoundation.org> <20230725104525.907419883@linuxfoundation.org> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230725104525.907419883@linuxfoundation.org> On Tue, Jul 25, 2023 at 12:44:26PM +0200, Greg Kroah-Hartman wrote: > From: Eric Biggers > > [ Upstream commit d3ca75a8b3d77f2788e6c119ea7c3e3a1ab1e1ca ] > > crypto_has_skcipher() and crypto_has_skcipher2() do the same thing: they > check for the availability of an algorithm of type skcipher, blkcipher, > or ablkcipher, which also meets any non-type constraints the caller > specified. And they have exactly the same prototype. > > Therefore, eliminate the redundancy by removing crypto_has_skcipher() > and renaming crypto_has_skcipher2() to crypto_has_skcipher(). > > Signed-off-by: Eric Biggers > Signed-off-by: Herbert Xu > Stable-dep-of: efbc7764c444 ("crypto: marvell/cesa - Fix type mismatch warning") > Signed-off-by: Sasha Levin > --- > crypto/skcipher.c | 4 ++-- > include/crypto/skcipher.h | 19 +------------------ > 2 files changed, 3 insertions(+), 20 deletions(-) How is this a Stable-dep-of "crypto: marvell/cesa - Fix type mismatch warning"? I don't understand why this is being backported. - Eric