From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B44F1FB4F for ; Tue, 1 Aug 2023 09:46:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0B90C433C9; Tue, 1 Aug 2023 09:46:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1690883196; bh=ClWwZd3CkcD88TAy1Isc5wAm/UF93+Dtw2FKyC5nWnc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mNrMmCN0yjzhpzywtMASz+sIbAJl2fU6HARYjC3Qn1+s+uQYbyXmGaHUIoVP586s3 WKOBf5qu/TmPDKVE5SZhrIDRBdXLDAoVht3Idrhj1BG4N/pZWBb4DwLhJ2rY4Ku2Jc afASzdToDgwiiSph+ueYaBJr8XyOmWzSvrtQE960= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Johan Hovold , Tony Lindgren , "Rafael J. Wysocki" Subject: [PATCH 6.4 149/239] serial: qcom-geni: drop bogus runtime pm state update Date: Tue, 1 Aug 2023 11:20:13 +0200 Message-ID: <20230801091931.038781012@linuxfoundation.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230801091925.659598007@linuxfoundation.org> References: <20230801091925.659598007@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Johan Hovold commit 4dd8752a14ca0303fbdf0a6c68ff65f0a50bd2fa upstream. The runtime PM state should not be changed by drivers that do not implement runtime PM even if it happens to work around a bug in PM core. With the wake irq arming now fixed, drop the bogus runtime PM state update which left the device in active state (and could potentially prevent a parent device from suspending). Fixes: f3974413cf02 ("tty: serial: qcom_geni_serial: Wakeup IRQ cleanup") Cc: 5.6+ # 5.6+ Signed-off-by: Johan Hovold Reviewed-by: Tony Lindgren Signed-off-by: Rafael J. Wysocki Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/qcom_geni_serial.c | 7 ------- 1 file changed, 7 deletions(-) --- a/drivers/tty/serial/qcom_geni_serial.c +++ b/drivers/tty/serial/qcom_geni_serial.c @@ -1676,13 +1676,6 @@ static int qcom_geni_serial_probe(struct if (ret) return ret; - /* - * Set pm_runtime status as ACTIVE so that wakeup_irq gets - * enabled/disabled from dev_pm_arm_wake_irq during system - * suspend/resume respectively. - */ - pm_runtime_set_active(&pdev->dev); - if (port->wakeup_irq > 0) { device_init_wakeup(&pdev->dev, true); ret = dev_pm_set_dedicated_wake_irq(&pdev->dev,