From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10116174CA for ; Wed, 9 Aug 2023 11:02:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87AE0C433C7; Wed, 9 Aug 2023 11:02:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1691578975; bh=Gw3ueeG8xgQsFn26viLDJJvO6y6+E1nOpEnokn4qqm4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Mi3r5W4dxnz7Esv31uyj0BY/CQI4RW6/y8J8COTBcOGtAoiwkC+UmqFkSnvm5Km0d 7TRfvRZOo0c27Bc7gvTIAHt94FRmh7iDbbbo/zqaAVjmGFUuN8A9sND89nPTLkRrJ6 VSZ3crb5rxQ8Ga2AVks3un+ama4eVNiIgtZWO+0A= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Roberto Sassu , Stefan Berger , Mimi Zohar , Sasha Levin Subject: [PATCH 4.14 013/204] evm: Complete description of evm_inode_setattr() Date: Wed, 9 Aug 2023 12:39:11 +0200 Message-ID: <20230809103643.029150193@linuxfoundation.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230809103642.552405807@linuxfoundation.org> References: <20230809103642.552405807@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Roberto Sassu [ Upstream commit b1de86d4248b273cb12c4cd7d20c08d459519f7d ] Add the description for missing parameters of evm_inode_setattr() to avoid the warning arising with W=n compile option. Fixes: 817b54aa45db ("evm: add evm_inode_setattr to prevent updating an invalid security.evm") # v3.2+ Fixes: c1632a0f1120 ("fs: port ->setattr() to pass mnt_idmap") # v6.3+ Signed-off-by: Roberto Sassu Reviewed-by: Stefan Berger Signed-off-by: Mimi Zohar Signed-off-by: Sasha Levin --- security/integrity/evm/evm_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/security/integrity/evm/evm_main.c b/security/integrity/evm/evm_main.c index 6e761b07cb3f0..9b75166619236 100644 --- a/security/integrity/evm/evm_main.c +++ b/security/integrity/evm/evm_main.c @@ -427,7 +427,9 @@ void evm_inode_post_removexattr(struct dentry *dentry, const char *xattr_name) /** * evm_inode_setattr - prevent updating an invalid EVM extended attribute + * @idmap: idmap of the mount * @dentry: pointer to the affected dentry + * @attr: iattr structure containing the new file attributes * * Permit update of file attributes when files have a valid EVM signature, * except in the case of them having an immutable portable signature. -- 2.39.2