From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2613F171B3 for ; Wed, 9 Aug 2023 11:03:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B814C433C7; Wed, 9 Aug 2023 11:03:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1691578996; bh=idVYCjaXdlrg9LiaDFeXzscraRX8knMQY7u/P5Pqhm8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tHyMIrGhzbZ8JLwbndmoI4fLCE7tZ650ilW2K0zZmZBIrXCDYxch9yAupEyptSgFJ NoZv1hm1kQzcl1CYyUpah9ntNdluSdmtqsKQZUNV4XGcCPSMF+T0ffkrt+Dk9ECJmN LCzbsgV9QPWZ9J8kX4iNK/TjUz49qt2VqXsuDBEI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Marek Vasut , Michael Hennerich , Dmitry Torokhov , Sasha Levin Subject: [PATCH 4.14 037/204] Input: adxl34x - do not hardcode interrupt trigger type Date: Wed, 9 Aug 2023 12:39:35 +0200 Message-ID: <20230809103643.808915042@linuxfoundation.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230809103642.552405807@linuxfoundation.org> References: <20230809103642.552405807@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Marek Vasut [ Upstream commit e96220bce5176ed2309f77f061dcc0430b82b25e ] Instead of hardcoding IRQ trigger type to IRQF_TRIGGER_HIGH, let's respect the settings specified in the firmware description. Fixes: e27c729219ad ("Input: add driver for ADXL345/346 Digital Accelerometers") Signed-off-by: Marek Vasut Acked-by: Michael Hennerich Link: https://lore.kernel.org/r/20230509203555.549158-1-marex@denx.de Signed-off-by: Dmitry Torokhov Signed-off-by: Sasha Levin --- drivers/input/misc/adxl34x.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/input/misc/adxl34x.c b/drivers/input/misc/adxl34x.c index 2e189646d8fe2..d56ab4b25edf4 100644 --- a/drivers/input/misc/adxl34x.c +++ b/drivers/input/misc/adxl34x.c @@ -811,8 +811,7 @@ struct adxl34x *adxl34x_probe(struct device *dev, int irq, AC_WRITE(ac, POWER_CTL, 0); err = request_threaded_irq(ac->irq, NULL, adxl34x_irq, - IRQF_TRIGGER_HIGH | IRQF_ONESHOT, - dev_name(dev), ac); + IRQF_ONESHOT, dev_name(dev), ac); if (err) { dev_err(dev, "irq %d busy?\n", ac->irq); goto err_free_mem; -- 2.39.2