From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BB2553B7 for ; Wed, 9 Aug 2023 11:04:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE6D5C433C7; Wed, 9 Aug 2023 11:04:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1691579046; bh=QeExGqki1VpYUBV3mS+Ufy5Y/4/AOLRhMsXkigV7dgk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SEKXap5BHIU/M+P7MXNk4I8bKQ+G4LoE5/OOl4hC7kptv6EuruP/5t9NlVuwKUh7f Ok3DReTb+Cfdq8gK92gxjmHfos68wrpMwQdw5pj7M8ADTKJdGsbkkELAnfYSFvjZrM /qYgGJ2ADkwYC6wT02TzInOfTtu0vuQb61ZzeDrE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dan Carpenter , Krzysztof Kozlowski , Sasha Levin Subject: [PATCH 4.14 056/204] w1: fix loop in w1_fini() Date: Wed, 9 Aug 2023 12:39:54 +0200 Message-ID: <20230809103644.483560489@linuxfoundation.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230809103642.552405807@linuxfoundation.org> References: <20230809103642.552405807@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Dan Carpenter [ Upstream commit 83f3fcf96fcc7e5405b37d9424c7ef26bfa203f8 ] The __w1_remove_master_device() function calls: list_del(&dev->w1_master_entry); So presumably this can cause an endless loop. Fixes: 7785925dd8e0 ("[PATCH] w1: cleanups.") Signed-off-by: Dan Carpenter Signed-off-by: Krzysztof Kozlowski Signed-off-by: Sasha Levin --- drivers/w1/w1.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index 4d43c373e5c64..cfba277bfd57f 100644 --- a/drivers/w1/w1.c +++ b/drivers/w1/w1.c @@ -1233,10 +1233,10 @@ static int __init w1_init(void) static void __exit w1_fini(void) { - struct w1_master *dev; + struct w1_master *dev, *n; /* Set netlink removal messages and some cleanup */ - list_for_each_entry(dev, &w1_masters, w1_master_entry) + list_for_each_entry_safe(dev, n, &w1_masters, w1_master_entry) __w1_remove_master_device(dev); w1_fini_netlink(); -- 2.39.2