From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7630717731 for ; Wed, 9 Aug 2023 11:06:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EBA95C433C7; Wed, 9 Aug 2023 11:06:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1691579210; bh=iudBw1+AR8C14+FxMr0Mi7sD6sTVtCktiY0tqXGjGt4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qlrdVDcLLaic5nvfKzt0JXG8Bodd1smYXORuCpF21nF5+zepQnwZXKlw9tNcBcY2Y w/x+19ys7ZLU+pMeXIqklivC3sfC4lEAF/rvoLO2O1akeSJcp78ptvi9/Ztgxl0YJN X8i9QLyJdQurgo5HcAL+IVuvJZostukGDFZr8Rvw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Krzysztof Kozlowski , Andi Shyti , Christophe JAILLET , Jiri Slaby Subject: [PATCH 4.14 115/204] tty: serial: samsung_tty: Fix a memory leak in s3c24xx_serial_getclk() in case of error Date: Wed, 9 Aug 2023 12:40:53 +0200 Message-ID: <20230809103646.442249017@linuxfoundation.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230809103642.552405807@linuxfoundation.org> References: <20230809103642.552405807@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Christophe JAILLET commit a9c09546e903f1068acfa38e1ee18bded7114b37 upstream. If clk_get_rate() fails, the clk that has just been allocated needs to be freed. Cc: # v3.3+ Reviewed-by: Krzysztof Kozlowski Reviewed-by: Andi Shyti Fixes: 5f5a7a5578c5 ("serial: samsung: switch to clkdev based clock lookup") Signed-off-by: Christophe JAILLET Reviewed-by: Jiri Slaby Message-ID: Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/samsung.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) --- a/drivers/tty/serial/samsung.c +++ b/drivers/tty/serial/samsung.c @@ -1177,8 +1177,12 @@ static unsigned int s3c24xx_serial_getcl continue; rate = clk_get_rate(clk); - if (!rate) + if (!rate) { + dev_err(ourport->port.dev, + "Failed to get clock rate for %s.\n", clkname); + clk_put(clk); continue; + } if (ourport->info->has_divslot) { unsigned long div = rate / req_baud;