From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FC3717731 for ; Wed, 9 Aug 2023 11:08:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13D89C433C9; Wed, 9 Aug 2023 11:08:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1691579327; bh=UbrUUWY8XJmLNYjq9stlryEFx2ZahC127QgtOTluVu0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fnq1jaisQuY9fh2IGSKvk7j8E88SEv0a7Tya/QnD7k7YBfgPLAojJtpuUzGFZyL/R ZXrK1opmyIKQe1krWlpKyUcy+XfRyoqlKQTHhahAZLE/tgsARHNqVKul5gzUTdWH6d wevgVD+EE9Im41i8+ZiUbP0vqblNTZHt8PGQW1/o= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Matus Gajdos , Fabio Estevam , Mark Brown , Sasha Levin Subject: [PATCH 4.14 156/204] ASoC: fsl_spdif: Silence output on stop Date: Wed, 9 Aug 2023 12:41:34 +0200 Message-ID: <20230809103647.766440468@linuxfoundation.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230809103642.552405807@linuxfoundation.org> References: <20230809103642.552405807@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Matus Gajdos [ Upstream commit 0e4c2b6b0c4a4b4014d9424c27e5e79d185229c5 ] Clear TX registers on stop to prevent the SPDIF interface from sending last written word over and over again. Fixes: a2388a498ad2 ("ASoC: fsl: Add S/PDIF CPU DAI driver") Signed-off-by: Matus Gajdos Reviewed-by: Fabio Estevam Link: https://lore.kernel.org/r/20230719164729.19969-1-matuszpd@gmail.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/fsl/fsl_spdif.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c index 7e6cc4da00887..b079754aed409 100644 --- a/sound/soc/fsl/fsl_spdif.c +++ b/sound/soc/fsl/fsl_spdif.c @@ -618,6 +618,8 @@ static int fsl_spdif_trigger(struct snd_pcm_substream *substream, case SNDRV_PCM_TRIGGER_PAUSE_PUSH: regmap_update_bits(regmap, REG_SPDIF_SCR, dmaen, 0); regmap_update_bits(regmap, REG_SPDIF_SIE, intr, 0); + regmap_write(regmap, REG_SPDIF_STL, 0x0); + regmap_write(regmap, REG_SPDIF_STR, 0x0); break; default: return -EINVAL; -- 2.40.1