From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2B0F1773D for ; Wed, 9 Aug 2023 11:19:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1CE93C433C8; Wed, 9 Aug 2023 11:19:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1691579976; bh=Ac3iihuNkiicyqBjRwIVnYIfYYzB5zvmQKyjwQV3Ivw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=a0GiSw2sYUFFngryVDz+U5SrJ71ok7ab1M2gva3tKVUzWUrMN4Fl7pZ8Jq1hI11rb AeSbw5Wp7i59dmti/D+alhQ5xYElNQ42OB42Xhxwp9v4CXQgkX8AZuZoxgpBBYUU80 Nl0V4X03n2xw5lD9w8gfV7m84zT/VJ+fI6Rve7NQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Shreyas Deodhar , Nilesh Javali , Himanshu Madhani , "Martin K. Petersen" Subject: [PATCH 4.19 184/323] scsi: qla2xxx: Pointer may be dereferenced Date: Wed, 9 Aug 2023 12:40:22 +0200 Message-ID: <20230809103706.586105564@linuxfoundation.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230809103658.104386911@linuxfoundation.org> References: <20230809103658.104386911@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Shreyas Deodhar commit 00eca15319d9ce8c31cdf22f32a3467775423df4 upstream. Klocwork tool reported pointer 'rport' returned from call to function fc_bsg_to_rport() may be NULL and will be dereferenced. Add a fix to validate rport before dereferencing. Cc: stable@vger.kernel.org Signed-off-by: Shreyas Deodhar Signed-off-by: Nilesh Javali Link: https://lore.kernel.org/r/20230607113843.37185-7-njavali@marvell.com Reviewed-by: Himanshu Madhani Signed-off-by: Martin K. Petersen Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/qla2xxx/qla_bsg.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/scsi/qla2xxx/qla_bsg.c +++ b/drivers/scsi/qla2xxx/qla_bsg.c @@ -2488,6 +2488,8 @@ qla24xx_bsg_request(struct bsg_job *bsg_ if (bsg_request->msgcode == FC_BSG_RPT_ELS) { rport = fc_bsg_to_rport(bsg_job); + if (!rport) + return ret; host = rport_to_shost(rport); vha = shost_priv(host); } else {