From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 578C922F02 for ; Thu, 10 Aug 2023 21:54:19 +0000 (UTC) Received: by mail-io1-f52.google.com with SMTP id ca18e2360f4ac-790b080f2a0so47173839f.3 for ; Thu, 10 Aug 2023 14:54:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1691704458; x=1692309258; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=d14ni5Xwha4b5W9oszHP598tb2kfEa4V0TQw+xddRLI=; b=sk6RGOXZlyzBLUxRikbrhW9UAO6qkV/Xz+zONz6SwWTI8aV5MGE2KOSRoSOiZrAb1w 6cyYKG5P/tZUMDBWjMKrTNfAbAx+eb0z775vqOOcYWZwyuTbXvLU8NnDmMYgPDuZOv9L 7rJdC2K72lt3lhOU0h3tfTdk9nD5Oo+ADK+xs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691704458; x=1692309258; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=d14ni5Xwha4b5W9oszHP598tb2kfEa4V0TQw+xddRLI=; b=Ibaf8N8qs7VYYQnBiaauhSn3dX7O4Frn+YPi0qOKLB6cSOfARMBMnLEilDuwd4z9V2 tFdogS5PCb0l1vqz8kInJtZSmerXtdeuGD0b5uRx8R7GvD5U8BzDCWFAZkwyabbOwtDn zCeGHtvrptZL0X1Fk1M9HjkrwVlQBLgP7sdsRs2JX99KBFjnzOsLSrB599/08yumiZ+1 tYNAdaiJBrLLcnE/RcHn/+CrxL9msPnlRnMutCrr2LEFpxqWtSerJ+92gYk1pnGGgibm H6/hQZGbhMqWel/HqYOaWR9Tu+pvYN/r7e41lT4sWXc3QX6FqLmpqYgKpgcPFKN9HkYv tDBA== X-Gm-Message-State: AOJu0YwVDbpxUQUadtXUcNXQc5Z9foWkwK1+cCL1apEdSJZ+eobUt4Dq igqIvyHezjMouHkFndJb/w5ALw== X-Google-Smtp-Source: AGHT+IGLuAl1KNMSS1xa6rv6PHxjZOWO+/xYanI4+8mudFtV7iuFx1l2FmZz3RioEc2UFfg3nig2lg== X-Received: by 2002:a6b:3108:0:b0:785:cfa1:fcac with SMTP id j8-20020a6b3108000000b00785cfa1fcacmr288189ioa.20.1691704458060; Thu, 10 Aug 2023 14:54:18 -0700 (PDT) Received: from localhost (156.190.123.34.bc.googleusercontent.com. [34.123.190.156]) by smtp.gmail.com with ESMTPSA id s10-20020a02cf2a000000b00430996b3604sm660842jar.125.2023.08.10.14.54.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Aug 2023 14:54:17 -0700 (PDT) Date: Thu, 10 Aug 2023 21:54:16 +0000 From: Joel Fernandes To: "Paul E. McKenney" Cc: Guenter Roeck , Greg Kroah-Hartman , stable@vger.kernel.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, shuah@kernel.org, patches@kernelci.org, lkft-triage@lists.linaro.org, pavel@denx.de, jonathanh@nvidia.com, f.fainelli@gmail.com, sudipm.mukherjee@gmail.com, srw@sladewatkins.net, rwarsow@gmx.de, conor@kernel.org Subject: Re: [PATCH 5.15 00/92] 5.15.126-rc1 review Message-ID: <20230810215416.GA562211@google.com> References: <20230809103633.485906560@linuxfoundation.org> <20230809135326.GE3031656@google.com> <35e4b770-2ead-4a19-ad01-fa75996adef4@roeck-us.net> <20230809201413.GA3374446@google.com> <6b05a082-41a7-f0cf-c0a4-1cced8d5a230@roeck-us.net> <4dbe72a3-50ea-051c-96ba-d709b33d3a98@roeck-us.net> <882a606f-5776-46d1-a423-2c5ea0a1cd8f@paulmck-laptop> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <882a606f-5776-46d1-a423-2c5ea0a1cd8f@paulmck-laptop> On Thu, Aug 10, 2023 at 10:55:16AM -0700, Paul E. McKenney wrote: > On Wed, Aug 09, 2023 at 02:45:44PM -0700, Guenter Roeck wrote: > > On 8/9/23 13:39, Joel Fernandes wrote: > > > On Wed, Aug 9, 2023 at 4:38 PM Guenter Roeck wrote: > > > > > > > > On 8/9/23 13:14, Joel Fernandes wrote: > > > > > On Wed, Aug 09, 2023 at 12:25:48PM -0700, Guenter Roeck wrote: > > > > > > On Wed, Aug 09, 2023 at 02:35:59PM -0400, Joel Fernandes wrote: > > > > > > > On Wed, Aug 9, 2023 at 12:18 PM Guenter Roeck wrote: > > > > > > > > > > > > > > > > On 8/9/23 06:53, Joel Fernandes wrote: > > > > > > > > > On Wed, Aug 09, 2023 at 12:40:36PM +0200, Greg Kroah-Hartman wrote: > > > > > > > > > > This is the start of the stable review cycle for the 5.15.126 release. > > > > > > > > > > There are 92 patches in this series, all will be posted as a response > > > > > > > > > > to this one. If anyone has any issues with these being applied, please > > > > > > > > > > let me know. > > > > > > > > > > > > > > > > > > > > Responses should be made by Fri, 11 Aug 2023 10:36:10 +0000. > > > > > > > > > > Anything received after that time might be too late. > > > > > > > > > > > > > > > > > > > > The whole patch series can be found in one patch at: > > > > > > > > > > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.126-rc1.gz > > > > > > > > > > or in the git tree and branch at: > > > > > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y > > > > > > > > > > and the diffstat can be found below. > > > > > > > > > > > > > > > > > > Not necesscarily new with 5.15 stable but 3 of the 19 rcutorture scenarios > > > > > > > > > hang with this -rc: TREE04, TREE07, TASKS03. > > > > > > > > > > > > > > > > > > 5.15 has a known stop machine issue where it hangs after 1.5 hours with cpu > > > > > > > > > hotplug rcutorture testing. Me and tglx are continuing to debug this. The > > > > > > > > > issue does not show up on anything but 5.15 stable kernels and neither on > > > > > > > > > mainline. > > > > > > > > > > > > > > > > > > > > > > > > > Do you by any have a crash pattern that we could possibly use to find the crash > > > > > > > > in ChromeOS crash logs ? No idea if that would help, but it could provide some > > > > > > > > additional data points. > > > > > > > > > > > > > > The pattern shows as a hard hang, the system is unresponsive and all CPUs > > > > > > > are stuck in stop_machine. Sometimes it recovers on its own from the > > > > > > > hang and then RCU immediately gives stall warnings. It takes 1.5 hour > > > > > > > to reproduce and sometimes never happens for several hours. > > > > > > > > > > > > > > It appears related to CPU hotplug since gdb showed me most of the CPUs > > > > > > > are spinning in multi_cpu_stop() / stop machine after the hang. > > > > > > > > > > > > > > > > > > > Hmm, we do see lots of soft lockups with multi_cpu_stop() in the backtrace, > > > > > > but not with v5.15.y but with v5.4.y. The actual hang is in stop_machine_yield(). > > > > > > > > > > Interesting. It looks similar as far as the stack dump in gdb goes, here are > > > > > the stacks I dumped with the hang I referred to: > > > > > https://paste.debian.net/1288308/ > > > > > > > > > > > > > That link gives me "Entry not found". > > > > > > Yeah that was weird. Here it is again: https://pastebin.com/raw/L3nv1kH2 > > > > I found a couple of crash reports from chromeos-5.10, one of them complaining > > about RCU issues. I sent you links via IM. Nothing from 5.15 or later, though. > > Is the crash showing the eternally refiring timer fixed by this commit? > > 53e87e3cdc15 ("timers/nohz: Last resort update jiffies on nohz_full IRQ entry") Ah I was just replying, I have been seeing really good results after applying the following 3 commits since yesterday: 53e87e3cdc15 ("timers/nohz: Last resort update jiffies on nohz_full IRQ entry") 5417ddc1cf1f ("timers/nohz: Switch to ONESHOT_STOPPED in the low-res handler when the tick is stopped") a1ff03cd6fb9 ("tick: Detect and fix jiffies update stall") 5417ddc1cf1f also mentioned a "tick storm" which is exactly what I was seeing. I did a lengthy test and everything is looking good. I'll send these out to the stable list. thanks, - Joel