From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 678AC9443 for ; Sun, 13 Aug 2023 21:21:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36A71C433C8; Sun, 13 Aug 2023 21:21:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1691961709; bh=+Jmxty0KlW7/uvSP6JHa4TnP+hiUxGVi+uMll3ZTEOg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VymHrVj6ktbEmPrlfq9b6Ux+zGS65+aP5VU4u4/+E25R1i5M0ALgXZu2vONYeewtP qmeNqfAuQRC0N+QZWusIk4ZRhTPJw4rR0uHlPtRlehM0oj7oOSTbQ6+tehqaMBVxTh 0RMOIrevds2bcQcPPQ8oBMkyR6yMX0UHWg1IcJmQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Guenter Roeck Subject: [PATCH 4.14 01/26] sparc: fix up arch_cpu_finalize_init() build breakage. Date: Sun, 13 Aug 2023 23:18:54 +0200 Message-ID: <20230813211703.032783700@linuxfoundation.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230813211702.980427106@linuxfoundation.org> References: <20230813211702.980427106@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In commit 39f0e159b8e8 ("sparc/cpu: Switch to arch_cpu_finalize_init()") the check for ARCH_HAS_CPU_FINALIZE_INIT was backported incorrectly to the SPARC config option, not SPARC32. This causes build problems for the sparc64 arch: sparc64-linux-ld: init/main.o: in function `start_kernel': main.c:(.init.text+0x77c): undefined reference to `arch_cpu_finalize_init' Fix this up by putting the option in the correct place. Reported-by: Guenter Roeck Link: https://lore.kernel.org/r/252c7673-53ee-4c4b-e5ef-5bb2c0416154@roeck-us.net Fixes: 39f0e159b8e8 ("sparc/cpu: Switch to arch_cpu_finalize_init()") Signed-off-by: Greg Kroah-Hartman --- arch/sparc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/sparc/Kconfig +++ b/arch/sparc/Kconfig @@ -12,7 +12,6 @@ config 64BIT config SPARC bool default y - select ARCH_HAS_CPU_FINALIZE_INIT if !SMP select ARCH_MIGHT_HAVE_PC_PARPORT if SPARC64 && PCI select ARCH_MIGHT_HAVE_PC_SERIO select OF @@ -48,6 +47,7 @@ config SPARC config SPARC32 def_bool !64BIT + select ARCH_HAS_CPU_FINALIZE_INIT if !SMP select GENERIC_ATOMIC64 select CLZ_TAB select HAVE_UID16