From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A49C14A81 for ; Thu, 24 Aug 2023 17:16:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF24DC433C8; Thu, 24 Aug 2023 17:16:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1692897394; bh=YQX6ZvAG92cb8AhIbV31HOeiAhtTtFPwr3W0Fjwbavw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DmF6JvrKXiwdCbccFhF7q+/cOv7vVhWdKD26hB8W3NXg1lNzoupQG1/eHwj7RYc6S F4DjHMFT/Ei+RKwKRwysaXdmzrBiQNvqg6hHFwPx7G9u8VLqzBgJeNGMK3jpS1XxjE DMGoCyMhtbFIjp1S4DVP3Jiq+49i0bb0VTJWpTw0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+cd311b1e43cc25f90d18@syzkaller.appspotmail.com, Jan Kara , Sasha Levin Subject: [PATCH 5.10 022/135] udf: Fix uninitialized array access for some pathnames Date: Thu, 24 Aug 2023 19:08:14 +0200 Message-ID: <20230824170618.104153737@linuxfoundation.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230824170617.074557800@linuxfoundation.org> References: <20230824170617.074557800@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jan Kara [ Upstream commit 028f6055c912588e6f72722d89c30b401bbcf013 ] For filenames that begin with . and are between 2 and 5 characters long, UDF charset conversion code would read uninitialized memory in the output buffer. The only practical impact is that the name may be prepended a "unification hash" when it is not actually needed but still it is good to fix this. Reported-by: syzbot+cd311b1e43cc25f90d18@syzkaller.appspotmail.com Link: https://lore.kernel.org/all/000000000000e2638a05fe9dc8f9@google.com Signed-off-by: Jan Kara Signed-off-by: Sasha Levin --- fs/udf/unicode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/udf/unicode.c b/fs/udf/unicode.c index 622569007b530..2142cbd1dde24 100644 --- a/fs/udf/unicode.c +++ b/fs/udf/unicode.c @@ -247,7 +247,7 @@ static int udf_name_from_CS0(struct super_block *sb, } if (translate) { - if (str_o_len <= 2 && str_o[0] == '.' && + if (str_o_len > 0 && str_o_len <= 2 && str_o[0] == '.' && (str_o_len == 1 || str_o[1] == '.')) needsCRC = 1; if (needsCRC) { -- 2.40.1