* [PATCH] drm/msm/dp: Add newlines to debug printks
@ 2023-08-25 23:01 Stephen Boyd
2023-08-25 23:30 ` Dmitry Baryshkov
2023-08-25 23:57 ` Abhinav Kumar
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Boyd @ 2023-08-25 23:01 UTC (permalink / raw)
To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov
Cc: linux-kernel, patches, linux-arm-msm, freedreno, dri-devel,
Kuogee Hsieh, Vinod Polimera
These debug printks are missing newlines, causing drm debug logs to be
hard to read. Add newlines so that the messages are on their own line.
Cc: Kuogee Hsieh <quic_khsieh@quicinc.com>
Cc: Vinod Polimera <quic_vpolimer@quicinc.com>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
---
drivers/gpu/drm/msm/dp/dp_link.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_link.c b/drivers/gpu/drm/msm/dp/dp_link.c
index 42427129acea..6375daaeb98e 100644
--- a/drivers/gpu/drm/msm/dp/dp_link.c
+++ b/drivers/gpu/drm/msm/dp/dp_link.c
@@ -1090,7 +1090,7 @@ int dp_link_process_request(struct dp_link *dp_link)
} else if (dp_link_read_psr_error_status(link)) {
DRM_ERROR("PSR IRQ_HPD received\n");
} else if (dp_link_psr_capability_changed(link)) {
- drm_dbg_dp(link->drm_dev, "PSR Capability changed");
+ drm_dbg_dp(link->drm_dev, "PSR Capability changed\n");
} else {
ret = dp_link_process_link_status_update(link);
if (!ret) {
@@ -1107,7 +1107,7 @@ int dp_link_process_request(struct dp_link *dp_link)
}
}
- drm_dbg_dp(link->drm_dev, "sink request=%#x",
+ drm_dbg_dp(link->drm_dev, "sink request=%#x\n",
dp_link->sink_request);
return ret;
}
base-commit: 706a741595047797872e669b3101429ab8d378ef
--
https://chromeos.dev
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/msm/dp: Add newlines to debug printks
2023-08-25 23:01 [PATCH] drm/msm/dp: Add newlines to debug printks Stephen Boyd
@ 2023-08-25 23:30 ` Dmitry Baryshkov
2023-08-25 23:57 ` Abhinav Kumar
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2023-08-25 23:30 UTC (permalink / raw)
To: Stephen Boyd
Cc: Rob Clark, Abhinav Kumar, linux-kernel, patches, linux-arm-msm,
freedreno, dri-devel, Kuogee Hsieh, Vinod Polimera
On Sat, 26 Aug 2023 at 02:01, Stephen Boyd <swboyd@chromium.org> wrote:
>
> These debug printks are missing newlines, causing drm debug logs to be
> hard to read. Add newlines so that the messages are on their own line.
>
> Cc: Kuogee Hsieh <quic_khsieh@quicinc.com>
> Cc: Vinod Polimera <quic_vpolimer@quicinc.com>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
> drivers/gpu/drm/msm/dp/dp_link.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Fixes: 601f0479c583 ("drm/msm/dp: add logs across DP driver for ease
of debugging")
Fixes: cd779808cccd ("drm/msm/dp: Add basic PSR support for eDP")
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
> diff --git a/drivers/gpu/drm/msm/dp/dp_link.c b/drivers/gpu/drm/msm/dp/dp_link.c
> index 42427129acea..6375daaeb98e 100644
> --- a/drivers/gpu/drm/msm/dp/dp_link.c
> +++ b/drivers/gpu/drm/msm/dp/dp_link.c
> @@ -1090,7 +1090,7 @@ int dp_link_process_request(struct dp_link *dp_link)
> } else if (dp_link_read_psr_error_status(link)) {
> DRM_ERROR("PSR IRQ_HPD received\n");
> } else if (dp_link_psr_capability_changed(link)) {
> - drm_dbg_dp(link->drm_dev, "PSR Capability changed");
> + drm_dbg_dp(link->drm_dev, "PSR Capability changed\n");
> } else {
> ret = dp_link_process_link_status_update(link);
> if (!ret) {
> @@ -1107,7 +1107,7 @@ int dp_link_process_request(struct dp_link *dp_link)
> }
> }
>
> - drm_dbg_dp(link->drm_dev, "sink request=%#x",
> + drm_dbg_dp(link->drm_dev, "sink request=%#x\n",
> dp_link->sink_request);
> return ret;
> }
>
> base-commit: 706a741595047797872e669b3101429ab8d378ef
> --
> https://chromeos.dev
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/msm/dp: Add newlines to debug printks
2023-08-25 23:01 [PATCH] drm/msm/dp: Add newlines to debug printks Stephen Boyd
2023-08-25 23:30 ` Dmitry Baryshkov
@ 2023-08-25 23:57 ` Abhinav Kumar
1 sibling, 0 replies; 3+ messages in thread
From: Abhinav Kumar @ 2023-08-25 23:57 UTC (permalink / raw)
To: Stephen Boyd, Rob Clark, Dmitry Baryshkov
Cc: linux-kernel, patches, linux-arm-msm, freedreno, dri-devel,
Kuogee Hsieh, Vinod Polimera
On 8/25/2023 4:01 PM, Stephen Boyd wrote:
> These debug printks are missing newlines, causing drm debug logs to be
> hard to read. Add newlines so that the messages are on their own line.
>
> Cc: Kuogee Hsieh <quic_khsieh@quicinc.com>
> Cc: Vinod Polimera <quic_vpolimer@quicinc.com>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
> drivers/gpu/drm/msm/dp/dp_link.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/dp/dp_link.c b/drivers/gpu/drm/msm/dp/dp_link.c
> index 42427129acea..6375daaeb98e 100644
> --- a/drivers/gpu/drm/msm/dp/dp_link.c
> +++ b/drivers/gpu/drm/msm/dp/dp_link.c
> @@ -1090,7 +1090,7 @@ int dp_link_process_request(struct dp_link *dp_link)
> } else if (dp_link_read_psr_error_status(link)) {
> DRM_ERROR("PSR IRQ_HPD received\n");
> } else if (dp_link_psr_capability_changed(link)) {
> - drm_dbg_dp(link->drm_dev, "PSR Capability changed");
> + drm_dbg_dp(link->drm_dev, "PSR Capability changed\n");
> } else {
> ret = dp_link_process_link_status_update(link);
> if (!ret) {
> @@ -1107,7 +1107,7 @@ int dp_link_process_request(struct dp_link *dp_link)
> }
> }
>
> - drm_dbg_dp(link->drm_dev, "sink request=%#x",
> + drm_dbg_dp(link->drm_dev, "sink request=%#x\n",
> dp_link->sink_request);
perhaps we can move sink_request to the previous line itself with this
patch and we can avoid the line break.
But thats a very minor comment, otherwise LGTM
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> return ret;
> }
>
> base-commit: 706a741595047797872e669b3101429ab8d378ef
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-25 23:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-25 23:01 [PATCH] drm/msm/dp: Add newlines to debug printks Stephen Boyd
2023-08-25 23:30 ` Dmitry Baryshkov
2023-08-25 23:57 ` Abhinav Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).