From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 232818F73 for ; Sat, 26 Aug 2023 10:14:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2DF23C433C8; Sat, 26 Aug 2023 10:14:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1693044865; bh=ybJLI7slSflIl+uCX3TYBYBC5GHQl2DQcKNHoInEn50=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=q/JD85vEeAtbXgMNR8W6kTlnPWuLvDWJpSBRh12YbykjA5i9PC4pn0khiJp8m1Ehj jR+io8bHTOGmb8KAfoC/DD5VV8K809CLe5ic2thhSgB4jlBzjw2vZ/uPMmGX4AiQzR /GCe3xVipGJpI8L4LuhhMzN9z78qyUXgi+xYRy+U= Date: Sat, 26 Aug 2023 12:14:22 +0200 From: Greg Kroah-Hartman To: Ivan Mikhaylov Cc: stable@vger.kernel.org, patches@lists.linux.dev, Paul Fertser , Simon Horman , "David S. Miller" , Sasha Levin Subject: Re: [PATCH 5.10 066/135] net/ncsi: change from ndo_set_mac_address to dev_set_mac_address Message-ID: <2023082659-operable-citadel-bdda@gregkh> References: <20230824170617.074557800@linuxfoundation.org> <20230824170620.057993946@linuxfoundation.org> <739b18f9dc2ae6cde7b1060ee8071d7687b5d4e3.camel@gmail.com> <2023082507-breezy-eastward-da6d@gregkh> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Aug 25, 2023 at 11:38:02AM +0300, Ivan Mikhaylov wrote: > On Fri, 2023-08-25 at 09:16 +0200, Greg Kroah-Hartman wrote: > > On Fri, Aug 25, 2023 at 09:24:46AM +0300, Ivan Mikhaylov wrote: > > > On Thu, 2023-08-24 at 19:08 +0200, Greg Kroah-Hartman wrote: > > > > 5.10-stable review patch.  If anyone has any objections, please > > > > let > > > > me know. > > > > > > > > ------------------ > > > > > > > > From: Ivan Mikhaylov > > > > > > > > [ Upstream commit 790071347a0a1a89e618eedcd51c687ea783aeb3 ] > > > > > > > > Change ndo_set_mac_address to dev_set_mac_address because > > > > dev_set_mac_address provides a way to notify network layer about > > > > MAC > > > > change. In other case, services may not aware about MAC change > > > > and > > > > keep > > > > using old one which set from network adapter driver. > > > > > > > > As example, DHCP client from systemd do not update MAC address > > > > without > > > > notification from net subsystem which leads to the problem with > > > > acquiring > > > > the right address from DHCP server. > > > > > > > > Fixes: cb10c7c0dfd9e ("net/ncsi: Add NCSI Broadcom OEM command") > > > > Cc: stable@vger.kernel.org # v6.0+ 2f38e84 net/ncsi: make one > > > > oem_gma > > > > function for all mfr id > > > > Signed-off-by: Paul Fertser > > > > Signed-off-by: Ivan Mikhaylov > > > > Reviewed-by: Simon Horman > > > > Signed-off-by: David S. Miller > > > > Signed-off-by: Sasha Levin > > > > --- > > > >  net/ncsi/ncsi-rsp.c | 5 +++-- > > > >  1 file changed, 3 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/net/ncsi/ncsi-rsp.c b/net/ncsi/ncsi-rsp.c > > > > index 888ccc2d4e34b..47ffb790ff99f 100644 > > > > --- a/net/ncsi/ncsi-rsp.c > > > > +++ b/net/ncsi/ncsi-rsp.c > > > > @@ -616,7 +616,6 @@ static int > > > > ncsi_rsp_handler_oem_mlx_gma(struct > > > > ncsi_request *nr) > > > >  { > > > >         struct ncsi_dev_priv *ndp = nr->ndp; > > > >         struct net_device *ndev = ndp->ndev.dev; > > > > -       const struct net_device_ops *ops = ndev->netdev_ops; > > > >         struct ncsi_rsp_oem_pkt *rsp; > > > >         struct sockaddr saddr; > > > >         int ret = 0; > > > > @@ -630,7 +629,9 @@ static int > > > > ncsi_rsp_handler_oem_mlx_gma(struct > > > > ncsi_request *nr) > > > >         /* Set the flag for GMA command which should only be > > > > called > > > > once */ > > > >         ndp->gma_flag = 1; > > > >   > > > > -       ret = ops->ndo_set_mac_address(ndev, &saddr); > > > > +       rtnl_lock(); > > > > +       ret = dev_set_mac_address(ndev, &saddr, NULL); > > > > +       rtnl_unlock(); > > > >         if (ret < 0) > > > >                 netdev_warn(ndev, "NCSI: 'Writing mac address to > > > > device failed\n"); > > > >   > > > > > > Greg, we had conversation in the past about this particular > > > patchset > > > series: > > > https://www.spinics.net/lists/stable-commits/msg308587.html > > > > > > Just one patch is not enough, I didn't test it either on linux > > > kernel > > > version < 6.0 , also I saw the Sasha's commits about the same for > > > 5.4, > > > 5.10, 5.15 and answered to him about necessity of two patchsets > > > instead > > > of one on 19 aug. > > > > Ah, so I should also include commit 74b449b98dcc ("net/ncsi: make one > > oem_gma function for all mfr id"), right? > > > > thanks, > > > > greg k-h > > Greg, yes, that's right and I'm not sure if these two patches applies > well for 5.x stable releases. Thanks, I've dropped this one patch for now , and will revisit this after this release to see if both work in these trees. greg k-h