From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1672118013 for ; Tue, 29 Aug 2023 18:47:42 +0000 (UTC) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1bf7423ef3eso29172875ad.3 for ; Tue, 29 Aug 2023 11:47:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1693334862; x=1693939662; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SP05QRX0ffgV9H75PNnPPPNwlPJBgrXfqON4q+7zQd8=; b=iR7CMZ2TOMm2oug+fW6PozLCKDS/FtBtnyhISmwLaudI+OQt4JkFh/4nfXqVS5T+x0 gc6XOEmfRRN6xM1lORZsVM7CD7pKalI9P9/iQA5HtQp5fiKBNFKY3340x/G8AX0+B02N KIsQX062xJPxzh2NKMuJVFoQ08gASaFeSb6N4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693334862; x=1693939662; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SP05QRX0ffgV9H75PNnPPPNwlPJBgrXfqON4q+7zQd8=; b=SwRaTrN7uCNZ2djoZJbNxNEj9pFDRvEgf3COIAsqI1uQiCps6ORTixFRHzWDvV+Fvm bJgq/9ya5JTRbw2Tln07Jrk4n3PbbTxpG0qtcSzxrlixkCFLw5Dig6PgPI9lXwuHUXeJ GUgve1CtZxePzG/RuXGeT19/Z0z1OAxm1XOXJZC8p9ZbYMBr1PYWNeKqux8NhxIO9tqc l0RKmy+SKM4Ttdi+gTOCRVlMUvSGd0MYSPWH76BcbvbDhx0uXNocBsFUMNuLHfYFdCMZ F/6inrefIXRaV7QfIYb06tqIlwMV3yETEGTmYJpuHSJA82wkYvunrjvaVJu/Sm/IVzY0 rNaw== X-Gm-Message-State: AOJu0YwLFVo9oBDcHq1RPgSY/MKGCRl5CIqr7Lbvjb5GijKZAIIxyRQX DdwnaX9QKwsnZ9JAfKY14AFnSw== X-Google-Smtp-Source: AGHT+IHGUmCHB6AjaXPnbvPgZPbqs96iezZg8UGYC+YUja3aAojoTLyujv9/gnvDjuZGMy/H54oFrA== X-Received: by 2002:a17:903:1212:b0:1b0:3df7:5992 with SMTP id l18-20020a170903121200b001b03df75992mr28283828plh.32.1693334862256; Tue, 29 Aug 2023 11:47:42 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:11a:201:d603:22a7:5e5e:d239]) by smtp.gmail.com with ESMTPSA id o15-20020a170902d4cf00b001b9e86e05b7sm9697953plg.0.2023.08.29.11.47.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Aug 2023 11:47:41 -0700 (PDT) From: Stephen Boyd To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev, Sean Paul , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Vinod Polimera , Kuogee Hsieh Subject: [PATCH 2/7] drm/msm/dp: Use drm_dp_read_sink_count() helper Date: Tue, 29 Aug 2023 11:47:27 -0700 Message-ID: <20230829184735.2841739-3-swboyd@chromium.org> X-Mailer: git-send-email 2.42.0.rc2.253.gd59a3bf2b4-goog In-Reply-To: <20230829184735.2841739-1-swboyd@chromium.org> References: <20230829184735.2841739-1-swboyd@chromium.org> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use the common function drm_dp_read_sink_count() instead of open-coding it. This shrinks the kernel text a tiny bit. Cc: Vinod Polimera Cc: Kuogee Hsieh Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_panel.c | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c index 09d4f6c38ef8..a0523b18b9e9 100644 --- a/drivers/gpu/drm/msm/dp/dp_panel.c +++ b/drivers/gpu/drm/msm/dp/dp_panel.c @@ -147,8 +147,8 @@ static int dp_panel_update_modes(struct drm_connector *connector, int dp_panel_read_sink_caps(struct dp_panel *dp_panel, struct drm_connector *connector) { - int rc = 0, bw_code; - int rlen, count; + int rc, bw_code; + int count; struct dp_panel_private *panel; if (!dp_panel || !connector) { @@ -174,16 +174,11 @@ int dp_panel_read_sink_caps(struct dp_panel *dp_panel, } if (dp_panel->dfp_present) { - rlen = drm_dp_dpcd_read(panel->aux, DP_SINK_COUNT, - &count, 1); - if (rlen == 1) { - count = DP_GET_SINK_COUNT(count); - if (!count) { - DRM_ERROR("no downstream ports connected\n"); - panel->link->sink_count = 0; - rc = -ENOTCONN; - goto end; - } + count = drm_dp_read_sink_count(panel->aux); + if (!count) { + DRM_ERROR("no downstream ports connected\n"); + panel->link->sink_count = 0; + return -ENOTCONN; } } -- https://chromeos.dev