patches.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [PATCH] lib/Kconfig.debug: Restrict DEBUG_INFO_SPLIT for RISC-V
@ 2023-08-16 17:35 Nathan Chancellor
  2023-08-16 22:04 ` Fangrui Song
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Nathan Chancellor @ 2023-08-16 17:35 UTC (permalink / raw)
  To: paul.walmsley, palmer, aou, akpm
  Cc: conor, ndesaulniers, trix, linux-riscv, llvm, patches,
	kernel test robot, Nathan Chancellor

When building for ARCH=riscv using LLVM < 14, there is an error with
CONFIG_DEBUG_INFO_SPLIT=y:

  error: A dwo section may not contain relocations

This was worked around in LLVM 15 by disallowing '-gsplit-dwarf' with
'-mrelax' (the default), so CONFIG_DEBUG_INFO_SPLIT is not selectable
with newer versions of LLVM:

  $ clang --target=riscv64-linux-gnu -gsplit-dwarf -c -o /dev/null -x c /dev/null
  clang: error: -gsplit-dwarf is unsupported with RISC-V linker relaxation (-mrelax)

GCC silently had a similar issue that was resolved with GCC 12.x.
Restrict CONFIG_DEBUG_INFO_SPLIT for RISC-V when using LLVM or GCC <
12.x to avoid these known issues.

Link: https://github.com/ClangBuiltLinux/linux/issues/1914
Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99090
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/all/202308090204.9yZffBWo-lkp@intel.com/
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
Since this only impacts RISC-V, it seems reasonable that this would go
in via their tree but I have added Andrew in case he wants to take it.
---
 lib/Kconfig.debug | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index d6798513a8c2..bd51274f4771 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -355,6 +355,11 @@ endchoice # "Compressed Debug information"
 config DEBUG_INFO_SPLIT
 	bool "Produce split debuginfo in .dwo files"
 	depends on $(cc-option,-gsplit-dwarf)
+	# RISC-V linker relaxation + -gsplit-dwarf has issues with LLVM and GCC
+	# prior to 12.x:
+	# https://github.com/llvm/llvm-project/issues/56642
+	# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99090
+	depends on !RISCV || GCC_VERSION >= 120000
 	help
 	  Generate debug info into separate .dwo files. This significantly
 	  reduces the build directory size for builds with DEBUG_INFO,

---
base-commit: 2ccdd1b13c591d306f0401d98dedc4bdcd02b421
change-id: 20230816-riscv-debug_info_split-0713571a1ac2

Best regards,
-- 
Nathan Chancellor <nathan@kernel.org>


^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2023-08-30 23:44 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-16 17:35 [PATCH] lib/Kconfig.debug: Restrict DEBUG_INFO_SPLIT for RISC-V Nathan Chancellor
2023-08-16 22:04 ` Fangrui Song
2023-08-16 22:35   ` Nick Desaulniers
2023-08-16 22:41     ` Fangrui Song
2023-08-16 22:43       ` Nick Desaulniers
2023-08-30 13:20 ` patchwork-bot+linux-riscv
2023-08-30 13:22 ` Palmer Dabbelt
2023-08-30 15:36   ` Nathan Chancellor
2023-08-30 23:44     ` Kees Cook

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).