From: Stephen Boyd <swboyd@chromium.org>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>,
Mark Gross <markgross@kernel.org>
Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev,
platform-driver-x86@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Prashant Malani <pmalani@chromium.org>,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>
Subject: [PATCH 0/3] platform/x86: intel_scu_ipc: Timeout fixes
Date: Wed, 30 Aug 2023 18:14:00 -0700 [thread overview]
Message-ID: <20230831011405.3246849-1-swboyd@chromium.org> (raw)
I recently looked at some crash reports on ChromeOS devices that call
into this intel_scu_ipc driver. They were hitting timeouts, and it
certainly looks possible for those timeouts to be triggering because of
scheduling issues. Once things started going south, the timeouts kept
coming. Maybe that's because the other side got seriously confused? I
don't know. I'll poke at it some more by injecting timeouts on the
kernel side.
The first two patches are only lightly tested (normal functions keep
working), while the third one is purely speculation. I was going to make
the interrupt delay for a long time to see if I could hit the timeout.
Stephen Boyd (3):
platform/x86: intel_scu_ipc: Check status after timeouts in
busy_loop()
platform/x86: intel_scu_ipc: Check status upon timeout in
ipc_wait_for_interrupt()
platform/x86: intel_scu_ipc: Fail IPC send if still busy
drivers/platform/x86/intel_scu_ipc.c | 59 ++++++++++++++++++++--------
1 file changed, 42 insertions(+), 17 deletions(-)
base-commit: 2dde18cd1d8fac735875f2e4987f11817cc0bc2c
--
https://chromeos.dev
next reply other threads:[~2023-08-31 1:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 1:14 Stephen Boyd [this message]
2023-08-31 1:14 ` [PATCH 1/3] platform/x86: intel_scu_ipc: Check status after timeouts in busy_loop() Stephen Boyd
2023-08-31 13:53 ` Andy Shevchenko
2023-09-05 22:24 ` Stephen Boyd
2023-09-06 13:58 ` Andy Shevchenko
2023-08-31 14:15 ` Kuppuswamy Sathyanarayanan
2023-09-01 5:50 ` Mika Westerberg
2023-09-05 22:27 ` Stephen Boyd
2023-09-06 13:46 ` Andy Shevchenko
2023-09-06 14:31 ` Mika Westerberg
2023-08-31 1:14 ` [PATCH 2/3] platform/x86: intel_scu_ipc: Check status upon timeout in ipc_wait_for_interrupt() Stephen Boyd
2023-08-31 13:58 ` Andy Shevchenko
2023-09-05 22:36 ` Stephen Boyd
2023-08-31 14:27 ` Kuppuswamy Sathyanarayanan
2023-09-05 22:56 ` Stephen Boyd
2023-09-01 6:04 ` Mika Westerberg
2023-08-31 1:14 ` [PATCH 3/3] platform/x86: intel_scu_ipc: Fail IPC send if still busy Stephen Boyd
2023-08-31 14:07 ` Andy Shevchenko
2023-09-01 6:06 ` Mika Westerberg
2023-09-05 22:42 ` Stephen Boyd
2023-08-31 3:28 ` [PATCH 0/3] platform/x86: intel_scu_ipc: Timeout fixes Kuppuswamy Sathyanarayanan
2023-09-05 22:55 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230831011405.3246849-1-swboyd@chromium.org \
--to=swboyd@chromium.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=patches@lists.linux.dev \
--cc=platform-driver-x86@vger.kernel.org \
--cc=pmalani@chromium.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).