From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FE9C7FB for ; Wed, 13 Sep 2023 18:38:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694630285; x=1726166285; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=27uuSgwznKYWiVr2rzZGk8zPvF6mY8zY3sne3jlCPzw=; b=L8Sdxj7ZsomctMAWA9g+tid5A0FMZ1XydthnIYCpwZEgEVCEpWnnoAbT JUdmgfYC3zTBJTgA9/D/9PbF45PXt4V5YcQrm0Bk/krcXZnAFJUxpHouq e+WdZ/2Z2aZN0/hHtcClzYjN4rdqPssOQEiiq197rkbZQfCkSLpRA3Pcr WFB7F9h6mZ9COwU3IiGUHZkpUrRrsimYNQsUXKN2fUDB6RHL+WDNQXg/U pMB8NEesxFI/nkQO4xETQ2yGvOdnKUFf/TrEKs9Xwim/iK2zLf3L5YrcZ 92pz6YMAMxC/Hx5Amd7/wGu1Z3FK+F66hLP+hFjudbeKCdgJHayyqwGjX w==; X-IronPort-AV: E=McAfee;i="6600,9927,10832"; a="369019180" X-IronPort-AV: E=Sophos;i="6.02,143,1688454000"; d="scan'208";a="369019180" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2023 11:37:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10832"; a="744238595" X-IronPort-AV: E=Sophos;i="6.02,143,1688454000"; d="scan'208";a="744238595" Received: from jithujos.sc.intel.com ([172.25.103.66]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2023 11:37:56 -0700 From: Jithu Joseph To: hdegoede@redhat.com, markgross@kernel.org Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, rostedt@goodmis.org, jithu.joseph@intel.com, ashok.raj@intel.com, tony.luck@intel.com, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, patches@lists.linux.dev, ravi.v.shankar@intel.com, pengfei.xu@intel.com Subject: [PATCH 07/10] platform/x86/intel/ifs: Metadata validation for start_chunk Date: Wed, 13 Sep 2023 11:33:45 -0700 Message-Id: <20230913183348.1349409-8-jithu.joseph@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230913183348.1349409-1-jithu.joseph@intel.com> References: <20230913183348.1349409-1-jithu.joseph@intel.com> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add an additional check to validate IFS image metadata field prior to loading the test image. If start_chunk is not a multiple of chunks_per_stride error out. Signed-off-by: Jithu Joseph Reviewed-by: Tony Luck Tested-by: Pengfei Xu --- drivers/platform/x86/intel/ifs/load.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/platform/x86/intel/ifs/load.c b/drivers/platform/x86/intel/ifs/load.c index 778a3b89a24d..88630366a23c 100644 --- a/drivers/platform/x86/intel/ifs/load.c +++ b/drivers/platform/x86/intel/ifs/load.c @@ -292,6 +292,13 @@ static int validate_ifs_metadata(struct device *dev) return ret; } + if (ifs_meta->chunks_per_stride && + (ifs_meta->starting_chunk % ifs_meta->chunks_per_stride)) { + dev_warn(dev, "Starting chunk num %d not a multiple of chunks_per_stride %d\n", + ifs_meta->starting_chunk, ifs_meta->chunks_per_stride); + return ret; + } + return 0; } -- 2.25.1