From: Justin Stitt <justinstitt@google.com>
To: Nathan Chancellor <nathan@kernel.org>
Cc: kent.overstreet@linux.dev, bfoster@redhat.com,
linux-bcachefs@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, patches@lists.linux.dev
Subject: Re: [PATCH 5/7] bcachefs: Fix -Wincompatible-function-pointer-types-strict from key_invalid callbacks
Date: Wed, 13 Sep 2023 21:57:52 +0000 [thread overview]
Message-ID: <20230913215752.dj3jbeth3j6f7udc@google.com> (raw)
In-Reply-To: <20230912-bcachefs-warning-fixes-v1-5-a1cc83a38836@kernel.org>
On Tue, Sep 12, 2023 at 12:15:42PM -0700, Nathan Chancellor wrote:
> When building bcachefs with -Wincompatible-function-pointer-types-strict,
> a clang warning designed to catch issues with mismatched function
> pointer types, which will be fatal at runtime due to kernel Control Flow
> Integrity (kCFI), there are several instances along the lines of:
>
> fs/bcachefs/bkey_methods.c:118:2: error: incompatible function pointer types initializing 'int (*)(const struct bch_fs *, struct bkey_s_c, enum bkey_invalid_flags, struct printbuf *)' with an expression of type 'int (const struct bch_fs *, struct bkey_s_c, unsigned int, struct printbuf *)' [-Werror,-Wincompatible-function-pointer-types-strict]
> 118 | BCH_BKEY_TYPES()
> | ^~~~~~~~~~~~~~~~
> fs/bcachefs/bcachefs_format.h:342:2: note: expanded from macro 'BCH_BKEY_TYPES'
> 342 | x(deleted, 0) \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> fs/bcachefs/bkey_methods.c:117:41: note: expanded from macro 'x'
> 117 | #define x(name, nr) [KEY_TYPE_##name] = bch2_bkey_ops_##name,
> | ^~~~~~~~~~~~~~~~~~~~
> <scratch space>:206:1: note: expanded from here
> 206 | bch2_bkey_ops_deleted
> | ^~~~~~~~~~~~~~~~~~~~~
> fs/bcachefs/bkey_methods.c:34:17: note: expanded from macro 'bch2_bkey_ops_deleted'
> 34 | .key_invalid = deleted_key_invalid, \
> | ^~~~~~~~~~~~~~~~~~~
>
> The flags parameter should be of type 'enum bkey_invalid_flags', not
> 'unsigned int'. Adjust the type everywhere so that there is no more
> warning.
>
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Justin Stitt <justinstitt@google.com>
> ---
> fs/bcachefs/bkey_methods.c | 10 +++++-----
> fs/bcachefs/subvolume.c | 2 +-
> fs/bcachefs/subvolume.h | 2 +-
> 3 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/fs/bcachefs/bkey_methods.c b/fs/bcachefs/bkey_methods.c
> index 6547142db428..2a284c954c7a 100644
> --- a/fs/bcachefs/bkey_methods.c
> +++ b/fs/bcachefs/bkey_methods.c
> @@ -25,7 +25,7 @@ const char * const bch2_bkey_types[] = {
> };
>
> static int deleted_key_invalid(const struct bch_fs *c, struct bkey_s_c k,
> - unsigned flags, struct printbuf *err)
> + enum bkey_invalid_flags flags, struct printbuf *err)
> {
> return 0;
> }
> @@ -39,7 +39,7 @@ static int deleted_key_invalid(const struct bch_fs *c, struct bkey_s_c k,
> })
>
> static int empty_val_key_invalid(const struct bch_fs *c, struct bkey_s_c k,
> - unsigned flags, struct printbuf *err)
> + enum bkey_invalid_flags flags, struct printbuf *err)
> {
> if (bkey_val_bytes(k.k)) {
> prt_printf(err, "incorrect value size (%zu != 0)",
> @@ -55,7 +55,7 @@ static int empty_val_key_invalid(const struct bch_fs *c, struct bkey_s_c k,
> })
>
> static int key_type_cookie_invalid(const struct bch_fs *c, struct bkey_s_c k,
> - unsigned flags, struct printbuf *err)
> + enum bkey_invalid_flags flags, struct printbuf *err)
> {
> return 0;
> }
> @@ -70,7 +70,7 @@ static int key_type_cookie_invalid(const struct bch_fs *c, struct bkey_s_c k,
> })
>
> static int key_type_inline_data_invalid(const struct bch_fs *c, struct bkey_s_c k,
> - unsigned flags, struct printbuf *err)
> + enum bkey_invalid_flags flags, struct printbuf *err)
> {
> return 0;
> }
> @@ -91,7 +91,7 @@ static void key_type_inline_data_to_text(struct printbuf *out, struct bch_fs *c,
> })
>
> static int key_type_set_invalid(const struct bch_fs *c, struct bkey_s_c k,
> - unsigned flags, struct printbuf *err)
> + enum bkey_invalid_flags flags, struct printbuf *err)
> {
> if (bkey_val_bytes(k.k)) {
> prt_printf(err, "incorrect value size (%zu != %zu)",
> diff --git a/fs/bcachefs/subvolume.c b/fs/bcachefs/subvolume.c
> index 0214a98deb4f..b371a5c4e06e 100644
> --- a/fs/bcachefs/subvolume.c
> +++ b/fs/bcachefs/subvolume.c
> @@ -99,7 +99,7 @@ int bch2_check_subvols(struct bch_fs *c)
> /* Subvolumes: */
>
> int bch2_subvolume_invalid(const struct bch_fs *c, struct bkey_s_c k,
> - unsigned flags, struct printbuf *err)
> + enum bkey_invalid_flags flags, struct printbuf *err)
> {
> if (bkey_lt(k.k->p, SUBVOL_POS_MIN) ||
> bkey_gt(k.k->p, SUBVOL_POS_MAX)) {
> diff --git a/fs/bcachefs/subvolume.h b/fs/bcachefs/subvolume.h
> index 8d4c50f4cd05..bb14f92e8687 100644
> --- a/fs/bcachefs/subvolume.h
> +++ b/fs/bcachefs/subvolume.h
> @@ -10,7 +10,7 @@ enum bkey_invalid_flags;
> int bch2_check_subvols(struct bch_fs *);
>
> int bch2_subvolume_invalid(const struct bch_fs *, struct bkey_s_c,
> - unsigned, struct printbuf *);
> + enum bkey_invalid_flags, struct printbuf *);
> void bch2_subvolume_to_text(struct printbuf *, struct bch_fs *, struct bkey_s_c);
>
> #define bch2_bkey_ops_subvolume ((struct bkey_ops) { \
>
> --
> 2.42.0
>
next prev parent reply other threads:[~2023-09-13 21:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 19:15 [PATCH 0/7] bcachefs compiler warning fixes for 32-bit Nathan Chancellor
2023-09-12 19:15 ` [PATCH 1/7] bcachefs: Fix -Wformat in bch2_set_bucket_needs_journal_commit() Nathan Chancellor
2023-09-13 21:42 ` Justin Stitt
2023-09-12 19:15 ` [PATCH 2/7] bcachefs: Fix -Wformat in bch2_btree_key_cache_to_text() Nathan Chancellor
2023-09-13 21:43 ` Justin Stitt
2023-09-12 19:15 ` [PATCH 3/7] bcachefs: Fix -Wformat in bch2_alloc_v4_invalid() Nathan Chancellor
2023-09-13 21:46 ` Justin Stitt
2023-09-12 19:15 ` [PATCH 4/7] bcachefs: Fix -Wformat in bch2_bucket_gens_invalid() Nathan Chancellor
2023-09-13 21:46 ` Justin Stitt
2023-09-12 19:15 ` [PATCH 5/7] bcachefs: Fix -Wincompatible-function-pointer-types-strict from key_invalid callbacks Nathan Chancellor
2023-09-13 21:57 ` Justin Stitt [this message]
2023-09-12 19:15 ` [PATCH 6/7] bcachefs: Fix -Wcompare-distinct-pointer-types in do_encrypt() Nathan Chancellor
2023-09-13 21:59 ` Justin Stitt
2023-09-12 19:15 ` [PATCH 7/7] bcachefs: Fix -Wcompare-distinct-pointer-types in bch2_copygc_get_buckets() Nathan Chancellor
2023-09-13 22:06 ` Justin Stitt
2023-09-12 19:36 ` [PATCH 0/7] bcachefs compiler warning fixes for 32-bit Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230913215752.dj3jbeth3j6f7udc@google.com \
--to=justinstitt@google.com \
--cc=bfoster@redhat.com \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=patches@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).