From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C0F52AB21 for ; Wed, 20 Sep 2023 12:02:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A426CC433C7; Wed, 20 Sep 2023 12:02:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1695211326; bh=BYW8HUiBF0kyh11FNsD+N4QIkPpCb+62heK35vtFuvY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=geexigheZhcU0sUyx9Cp4+lUOTZZlrzJBFMTGepH1SY8qe6g13mcajeT9Nz4nveBe iuJtPNhEM2MdDfa7SPrle91TNWEKX24deRc/nUPAaHYcmYRbm3ps97mSiV6FjTeqEZ 3eTBzpRRxwj5rAXedoW9d+10QJiJVcV2DwIye5FM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Gaurav Jain , Meenakshi Aggarwal , Herbert Xu , Sasha Levin Subject: [PATCH 4.14 044/186] crypto: caam - fix unchecked return value error Date: Wed, 20 Sep 2023 13:29:07 +0200 Message-ID: <20230920112838.529221033@linuxfoundation.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230920112836.799946261@linuxfoundation.org> References: <20230920112836.799946261@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Gaurav Jain [ Upstream commit e30685204711a6be40dec2622606950ccd37dafe ] error: Unchecked return value (CHECKED_RETURN) check_return: Calling sg_miter_next without checking return value fix: added check if(!sg_miter_next) Fixes: 8a2a0dd35f2e ("crypto: caam - strip input zeros from RSA input buffer") Signed-off-by: Gaurav Jain Signed-off-by: Meenakshi Aggarwal Reviewed-by: Gaurav Jain Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- drivers/crypto/caam/caampkc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/caam/caampkc.c b/drivers/crypto/caam/caampkc.c index 6f3f81bb880b5..01f9053db287b 100644 --- a/drivers/crypto/caam/caampkc.c +++ b/drivers/crypto/caam/caampkc.c @@ -194,7 +194,9 @@ static int caam_rsa_count_leading_zeros(struct scatterlist *sgl, if (len && *buff) break; - sg_miter_next(&miter); + if (!sg_miter_next(&miter)) + break; + buff = miter.addr; len = miter.length; -- 2.40.1