From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BBFA30FA7 for ; Wed, 20 Sep 2023 12:26:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D765C433D9; Wed, 20 Sep 2023 12:26:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1695212804; bh=n5CPYzup0Bu0Qh04ANN/puxllA/EFSP+y0SfKAW98Nc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CmSVyEV+LEo13UWABPT3Kp1+RSZOJLMv5bWpc5SUDWCJFY/1Z/4MlFn2zqcPXPbTP 2CCQ4VHQ6apYdMh5ViqV6yhy7ILZt6dhB1Ct+q8NOAqpYc5Se3aZFPAL/l7HDYuvtp Dgpoutq+vsAYI8UaCzsHi00KwRmGYFyXaacj2YoE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Wang Ming , Christian Brauner , Sasha Levin Subject: [PATCH 5.4 052/367] fs: Fix error checking for d_hash_and_lookup() Date: Wed, 20 Sep 2023 13:27:09 +0200 Message-ID: <20230920112859.842870686@linuxfoundation.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230920112858.471730572@linuxfoundation.org> References: <20230920112858.471730572@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Wang Ming [ Upstream commit 0d5a4f8f775ff990142cdc810a84eae078589d27 ] The d_hash_and_lookup() function returns error pointers or NULL. Most incorrect error checks were fixed, but the one in int path_pts() was forgotten. Fixes: eedf265aa003 ("devpts: Make each mount of devpts an independent filesystem.") Signed-off-by: Wang Ming Message-Id: <20230713120555.7025-1-machel@vivo.com> Signed-off-by: Christian Brauner Signed-off-by: Sasha Levin --- fs/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/namei.c b/fs/namei.c index 21988d22399f9..f6708ab8ec7ed 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -2603,7 +2603,7 @@ int path_pts(struct path *path) this.name = "pts"; this.len = 3; child = d_hash_and_lookup(parent, &this); - if (!child) + if (IS_ERR_OR_NULL(child)) return -ENOENT; path->dentry = child; -- 2.40.1