From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98C35525D; Tue, 26 Sep 2023 06:31:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95B88C433C7; Tue, 26 Sep 2023 06:31:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1695709866; bh=zTaUbCWNmUZ8OqLFafBNMG+qzSrLIujE0F+gyn3vzlQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NUNdNSC2HbBJlNxtjhT2Tyvv/GHWKXVtsgnABl9D2Y1b7abCbfZf8vsiTh2BFjFRr 8BAolH0Hw0lLTPRWRgo9iWHmeavC6cw7MvgQj5ESmLqCtiyts0eLxcXcIirODiomix t+wmDtuxIbJBUS0D7YiDAo1nBg0G20LQPvLp4NEo= Date: Tue, 26 Sep 2023 08:31:03 +0200 From: Greg KH To: Wei Liu Cc: Nuno Das Neves , linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, patches@lists.linux.dev, mikelley@microsoft.com, kys@microsoft.com, haiyangz@microsoft.com, decui@microsoft.com, apais@linux.microsoft.com, Tianyu.Lan@microsoft.com, ssengar@linux.microsoft.com, mukeshrathor@microsoft.com, stanislav.kinsburskiy@gmail.com, jinankjain@linux.microsoft.com, vkuznets@redhat.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, will@kernel.org, catalin.marinas@arm.com Subject: Re: [PATCH v3 15/15] Drivers: hv: Add modules to expose /dev/mshv to VMMs running on Hyper-V Message-ID: <2023092614-tummy-dwelling-7063@gregkh> References: <1695407915-12216-1-git-send-email-nunodasneves@linux.microsoft.com> <1695407915-12216-16-git-send-email-nunodasneves@linux.microsoft.com> <2023092342-staunch-chafe-1598@gregkh> <2023092630-masculine-clinic-19b6@gregkh> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Sep 26, 2023 at 05:54:34AM +0000, Wei Liu wrote: > On Tue, Sep 26, 2023 at 06:52:46AM +0200, Greg KH wrote: > > On Mon, Sep 25, 2023 at 05:07:24PM -0700, Nuno Das Neves wrote: > > > On 9/23/2023 12:58 AM, Greg KH wrote: > > > > Also, drivers should never call pr_*() calls, always use the proper > > > > dev_*() calls instead. > > > > > > > > > > We only use struct device in one place in this driver, I think that is the > > > only place it makes sense to use dev_*() over pr_*() calls. > > > > Then the driver needs to be fixed to use struct device properly so that > > you do have access to it when you want to print messages. That's a > > valid reason to pass around your device structure when needed. > > Greg, ACRN and Nitro drivers do not pass around the device structure. > Instead, they rely on a global struct device. We can follow the same. A single global struct device is wrong, please don't do that. Don't copy bad design patterns from other drivers, be better :) thanks, greg k-h