From: Stephen Boyd <swboyd@chromium.org>
To: Benson Leung <bleung@chromium.org>, Tzung-Bi Shih <tzungbi@kernel.org>
Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev,
chrome-platform@lists.linux.dev,
Prashant Malani <pmalani@chromium.org>
Subject: [PATCH 3/4] platform/chrome: cros_typec_vdm: Mark port_amode_ops const
Date: Mon, 2 Oct 2023 17:34:27 -0700 [thread overview]
Message-ID: <20231003003429.1378109-4-swboyd@chromium.org> (raw)
In-Reply-To: <20231003003429.1378109-1-swboyd@chromium.org>
Mark this struct of functions const so it moves to RO memory.
Cc: Prashant Malani <pmalani@chromium.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
---
drivers/platform/chrome/cros_typec_vdm.c | 2 +-
drivers/platform/chrome/cros_typec_vdm.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/chrome/cros_typec_vdm.c b/drivers/platform/chrome/cros_typec_vdm.c
index 20515ee0a20e..3f632fd35000 100644
--- a/drivers/platform/chrome/cros_typec_vdm.c
+++ b/drivers/platform/chrome/cros_typec_vdm.c
@@ -142,7 +142,7 @@ static int cros_typec_port_amode_vdm(struct typec_altmode *amode, const u32 hdr,
sizeof(req), NULL, 0);
}
-struct typec_altmode_ops port_amode_ops = {
+const struct typec_altmode_ops port_amode_ops = {
.enter = cros_typec_port_amode_enter,
.vdm = cros_typec_port_amode_vdm,
};
diff --git a/drivers/platform/chrome/cros_typec_vdm.h b/drivers/platform/chrome/cros_typec_vdm.h
index 95a6a75d32b6..631bd2ce4b00 100644
--- a/drivers/platform/chrome/cros_typec_vdm.h
+++ b/drivers/platform/chrome/cros_typec_vdm.h
@@ -5,7 +5,7 @@
#include <linux/usb/typec_altmode.h>
-extern struct typec_altmode_ops port_amode_ops;
+extern const struct typec_altmode_ops port_amode_ops;
void cros_typec_handle_vdm_attention(struct cros_typec_data *typec, int port_num);
void cros_typec_handle_vdm_response(struct cros_typec_data *typec, int port_num);
--
https://chromeos.dev
next prev parent reply other threads:[~2023-10-03 0:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 0:34 [PATCH 0/4] platform/chrome: Random driver cleanups Stephen Boyd
2023-10-03 0:34 ` [PATCH 1/4] platform/chrome: cros_ec_typec: Use semi-colons instead of commas Stephen Boyd
2023-10-03 0:34 ` [PATCH 2/4] platform/chrome: cros_ec_typec: Use dev_err_probe() more Stephen Boyd
2023-10-03 0:34 ` Stephen Boyd [this message]
2023-10-03 0:34 ` [PATCH 4/4] platform/chrome: cros_ec_proto: Mark outdata as const Stephen Boyd
2023-10-03 22:11 ` [PATCH 0/4] platform/chrome: Random driver cleanups Prashant Malani
2023-10-04 3:50 ` patchwork-bot+chrome-platform
2023-10-05 1:56 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231003003429.1378109-4-swboyd@chromium.org \
--to=swboyd@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=pmalani@chromium.org \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).