From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A18AC125B7 for ; Fri, 6 Oct 2023 11:03:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="iap8k9+2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79195C433C8; Fri, 6 Oct 2023 11:03:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1696590214; bh=4dpi9ypq5NwCfCKs6ejpxDxyw5e1ui6rbvUNhVADCX8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iap8k9+2BfdKoxzManX2E7z7pwLNnFzFY/YTlIju+84XyKTpK/c70RDTn6S8Q/V/H tkxTI7v8YEi17QWcToU5386tE7p++NwPuUz3dKgqnt7yf8kKKj7LsFuSdXFWVo35ry kJYkDwEnps1gY7dEkn1j1rV8NtklDJ5bT68ZebHg= Date: Fri, 6 Oct 2023 13:03:30 +0200 From: Greg Kroah-Hartman To: Harshit Mogalapalli Cc: Florian Fainelli , stable@vger.kernel.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org, patches@kernelci.org, lkft-triage@lists.linaro.org, pavel@denx.de, jonathanh@nvidia.com, sudipm.mukherjee@gmail.com, srw@sladewatkins.net, rwarsow@gmx.de, conor@kernel.org, Vegard Nossum , Darren Kenny Subject: Re: [PATCH 5.15 000/183] 5.15.134-rc1 review Message-ID: <2023100610-purge-pupil-b754@gregkh> References: <20231004175203.943277832@linuxfoundation.org> <2023100601-ending-prevalent-c8d4@gregkh> <9fec75ba-a319-027c-6cf2-b65e703d3ce7@oracle.com> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9fec75ba-a319-027c-6cf2-b65e703d3ce7@oracle.com> On Fri, Oct 06, 2023 at 04:07:14PM +0530, Harshit Mogalapalli wrote: > > > On 06/10/23 3:55 pm, Greg Kroah-Hartman wrote: > > On Wed, Oct 04, 2023 at 11:43:46AM -0700, Florian Fainelli wrote: > > > On 10/4/23 10:53, Greg Kroah-Hartman wrote: > > > > This is the start of the stable review cycle for the 5.15.134 release. > > > > There are 183 patches in this series, all will be posted as a response > > > > to this one. If anyone has any issues with these being applied, please > > > > let me know. > > > > > > > > Responses should be made by Fri, 06 Oct 2023 17:51:12 +0000. > > > > Anything received after that time might be too late. > > > > > > > > The whole patch series can be found in one patch at: > > > > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.134-rc1.gz > > > > or in the git tree and branch at: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y > > > > and the diffstat can be found below. > > > > > > > > thanks, > > > > > > > > greg k-h > > > > > > perf fails to build with: > > > > > > CC /local/users/fainelli/buildroot/output/arm/build/linux-custom/tools/perf/util/metricgroup.o > > > util/metricgroup.c: In function 'metricgroup__parse_groups': > > > util/metricgroup.c:1261:7: error: 'table' undeclared (first use in this > > > function) > > > if (!table) > > > ^~~~~ > > > util/metricgroup.c:1261:7: note: each undeclared identifier is reported only > > > once for each function it appears in > > > make[6]: *** [/local/users/fainelli/buildroot/output/arm/build/linux-custom/tools/build/Makefile.build:97: /local/users/fainelli/buildroot/output/arm/build/linux-custom/tools/perf/util/metricgroup.o] > > > Error 1 > > > > > > caused by c1ef510a0f2a879bf29ddebae766ec9f0790eb8f ("perf metric: Return > > > early if no CPU PMU table exists"). Dropping this commit allows the build to > > > continue. > > > > > > I had reported in the previous cycle that 00facc760903be66 ("perf jevents: > > > Switch build to use jevents.py") was causing build failures: > > > > > > https://lore.kernel.org/all/6a577578-8adb-aa70-1bf8-b1a4573152cf@gmail.com/ > > > > > > do we still want these commits to be included? > > > > No, I'll go drop them now, thanks for the report. > > Thought: > It's not the first time we see build failures in tools/perf -- would it make > sense to add this to your own build tests to reduce the round trip time for > these errors ? Last time I tried to build perf, I couldn't do it at all so I just gave up trying to test for it :) > Note: After reverting three patches in perf/ the build succeeds: > > Patch 151: c1ef510a0f2a perf metric: Return early if no CPU PMU table exists > Patch 81: 40ddac4ffc75 perf build: Update build rule for generated files > Patch 80: 8df938ed8c8a perf jevents: Switch build to use jevents.py All of these are now dropped. thanks, greg k-h